walletdb: refactor Read, Write, Erase, and Exists into non-template func
ClosedPublic
Actions

Authored by PiRK on Jun 1 2021, 15:29.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC7a2391c93f6d: walletdb: refactor Read, Write, Erase, and Exists into non-template func

Summary

In order to override these later, the specific details of how the Read,
Write, Erase, and Exists functions interact with the actual database
file need to go into functions that are not templated.

This is a backport of core#19292

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 1 2021, 15:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 1 2021, 15:29

PiRK requested review of this revision.Jun 1 2021, 15:29

teamcity edited the summary of this revision. (Show Details)Jun 1 2021, 15:30

deadalnix accepted this revision.Jun 1 2021, 15:31

This revision is now accepted and ready to land.Jun 1 2021, 15:31

Harbormaster completed remote builds in B15870: Diff 28700.Jun 1 2021, 15:39

Closed by commit rABC7a2391c93f6d: walletdb: refactor Read, Write, Erase, and Exists into non-template func (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyJun 2 2021, 06:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7a2391c93f6d: walletdb: refactor Read, Write, Erase, and Exists into non-template func.

Revision Contents
Changeset List

Path

Size

src/

wallet/

bdb.h

56 lines

bdb.cpp

69 lines

Diff 28709

View Options

src/wallet/bdb.h