Page MenuHomePhabricator

[avalanche] Fix a couple typo in comments
ClosedPublic

Authored by Fabien on Jun 23 2021, 18:32.

Details

Reviewers
Mengerian
Group Reviewers
Restricted Project
Commits
rABC00a0233de400: [avalanche] Fix a couple typo in comments
Summary

As per title.

Test Plan

Read the comments.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jun 23 2021, 18:32

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_proof_inventory.py ======

------- Stdout: -------
2021-06-23T18:41:47.684000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_184135/abc_p2p_proof_inventory_376
2021-06-23T18:41:48.601000Z TestFramework (INFO): Test sending a proof to our peers
2021-06-23T18:41:53.354000Z TestFramework (INFO): Test that we don't send the same inv several times
2021-06-23T18:41:54.679000Z TestFramework (INFO): Test a peer is created on proof reception
2021-06-23T18:41:54.913000Z TestFramework (INFO): Test receiving a proof with missing utxo is orphaned
2021-06-23T18:42:02.917000Z TestFramework (INFO): Nodes should eventually get the proof from their peer
2021-06-23T18:42:04.974000Z TestFramework (INFO): Test broadcasting proofs
2021-06-23T18:42:08.726000Z TestFramework (INFO): Proofs that become invalid should no longer be broadcasted
2021-06-23T18:42:11.992000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_proof_inventory.py", line 295, in run_test
    self.test_unbroadcast()
  File "/work/test/functional/abc_p2p_proof_inventory.py", line 281, in test_unbroadcast
    assert_equal(raw_proof["orphan"], True)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(False == True)
2021-06-23T18:42:12.043000Z TestFramework (INFO): Stopping nodes
2021-06-23T18:42:19.811000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_184135/abc_p2p_proof_inventory_376
2021-06-23T18:42:19.811000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_184135/abc_p2p_proof_inventory_376/test_framework.log
2021-06-23T18:42:19.811000Z TestFramework (ERROR): 
2021-06-23T18:42:19.811000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_184135/abc_p2p_proof_inventory_376' to consolidate all logs
2021-06-23T18:42:19.811000Z TestFramework (ERROR): 
2021-06-23T18:42:19.811000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T18:42:19.811000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T18:42:19.812000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_proof_inventory.py

This revision is now accepted and ready to land.Jun 23 2021, 20:32
This revision was landed with ongoing or failed builds.Jun 24 2021, 06:10
This revision was automatically updated to reflect the committed changes.