Work around memory-aliasing in descriptor ParsePubkey
ClosedPublic
Actions

Authored by PiRK on Jun 30 2021, 13:20.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC210f991f78ac: Work around memory-aliasing in descriptor ParsePubkey

Summary

Having a.size()==0 and then access a[0] is undefined behavior.

Add Span::empty() and use it in script/descriptor

This is a backport of core#19508

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 30 2021, 13:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2021, 13:20

PiRK requested review of this revision.Jun 30 2021, 13:20

teamcity edited the summary of this revision. (Show Details)Jun 30 2021, 13:20

Harbormaster completed remote builds in B16077: Diff 29013.Jun 30 2021, 13:35

majcosta accepted this revision.Jun 30 2021, 14:01

This revision is now accepted and ready to land.Jun 30 2021, 14:01

Closed by commit rABC210f991f78ac: Work around memory-aliasing in descriptor ParsePubkey (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJun 30 2021, 14:33

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC210f991f78ac: Work around memory-aliasing in descriptor ParsePubkey.

Revision Contents
Changeset List

Path

Size

src/

script/

descriptor.cpp

8 lines

span.h

1 line

Diff 29015

View Options

src/script/descriptor.cpp