Differential D974

Actually run assumevalid.py.
ClosedPublic
Actions

Authored by deadalnix on Jan 17 2018, 18:03.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING8cdda9f61858: Actually run assumevalid.py.
rABC8cdda9f61858: Actually run assumevalid.py.

Summary

assumevalid was merged as part of PR 9484, but was not added to the
test_runner, so is not run even as part of the extended tests.

This commit adds assumevalid to the list of tests in test_runner. It
also clarifies the code in assumevalid considerably.

This is a backport of core's PR10073

Test Plan

make check
./test/functional/test_runner.py assumevalid.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 17 2018, 18:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2018, 18:03

Harbormaster completed remote builds in B1645: Diff 2565.Jan 17 2018, 18:03

deadalnix mentioned this in D968: Remove SingleNodeConnCB.Jan 17 2018, 23:15

schancel accepted this revision.Jan 17 2018, 23:46

This revision is now accepted and ready to land.Jan 17 2018, 23:46

Closed by commit rABC8cdda9f61858: Actually run assumevalid.py. (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyJan 18 2018, 00:03

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

test/

functional/

assumevalid.py

107 lines

test_runner.py

1 line

Diff 2571

View Options

test/functional/assumevalid.py