Page MenuHomePhabricator

[cashtab-components] rebrand support
ClosedPublic

Authored by josephroyking on Tue, Jul 13, 22:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe982001851d6: [cashtab-components] rebrand support
Summary

XEC support for cashtab react components.

Test Plan
cd web/cashtab-components
npm run storybook

Click button under CashtabBadge (price in fiat) to verify extension opens with XEC transaction of correct amount
Click button under CashtabBadge (price in eToken) to verify that extension DOES NOT open

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Thu, Jul 15, 08:56
Fabien added a subscriber: Fabien.

This still uses the old address prefix

This revision now requires changes to proceed.Thu, Jul 15, 08:56

Replace bitcoincash: and simpleledger: addresses with ecash: and etoken:

Fabien requested changes to this revision.Thu, Jul 15, 14:36
Fabien added inline comments.
web/cashtab-components/src/hoc/CashtabBase/CashtabBase.tsx
184 ↗(On Diff #29201)

This seems unrelated to the changes, and maybe deserve a meaningful error message ?

209 ↗(On Diff #29201)

I suppose it's not needed because it's a lib ? In any case this doesn't belong to this patch

This revision now requires changes to proceed.Thu, Jul 15, 14:36
web/cashtab-components/src/hoc/CashtabBase/CashtabBase.tsx
184 ↗(On Diff #29201)

will include in separate diff

209 ↗(On Diff #29201)

will move to separate diff

Remove changes unrelated to this diff

This revision is now accepted and ready to land.Fri, Jul 16, 11:29