Differential D9877

Replace boost::shared_mutex and shared_lock with their std:: equivalent in rwcollection.h
ClosedPublic
Actions

Authored by Fabien on Aug 13 2021, 13:17.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCd5746a9c3540: Replace boost::shared_mutex and shared_lock with their std:: equivalent in…

Summary

This is possible since we use C++17.

Note that core raised some concerns about std::shared_mutex because of a couple bad glibc bugs that could cause deadlocks (https://github.com/bitcoin/bitcoin/issues/16684#issuecomment-726214696), so I checked that our release building version (Debian 10) was patched. As far as I can tell all our officially supported Linux are safe (all the ones we provide packages for). The only major distro I don't know for sure is CentOS 8, which runs a patched 2.28 version.

Ref T1634.

Test Plan

ninja all check-all
./contrib/teamcity/build-configurations.py build-tsan

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 13 2021, 13:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 13 2021, 13:17

Fabien requested review of this revision.Aug 13 2021, 13:17

Harbormaster completed remote builds in B16320: Diff 29402.Aug 13 2021, 13:28

majcosta accepted this revision.Aug 13 2021, 19:59

This revision is now accepted and ready to land.Aug 13 2021, 19:59

Closed by commit rABCd5746a9c3540: Replace boost::shared_mutex and shared_lock with their std:: equivalent in… (authored by Fabien). · Explain WhyAug 16 2021, 08:11

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd5746a9c3540: Replace boost::shared_mutex and shared_lock with their std:: equivalent in….

Revision Contents
Changeset List

Path

Size

src/

rwcollection.h

14 lines

test/

lint/

lint-boost-dependencies.sh

1 line

Diff 29417

View Options

src/rwcollection.h