Page MenuHomePhabricator

[avalanche] Move the VoteRecord to its own header
ClosedPublic

Authored by Fabien on Aug 13 2021, 14:03.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCfcf4f81dca8e: [avalanche] Move the VoteRecord to its own header
Summary

This will make it easier to reuse for voting on proofs.

Ref T1634.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Aug 13 2021, 14:03

Tail of the build log:

[386/442] Running utility command for check-bitcoin-torcontrol_tests
[387/442] bitcoin: testing settings_tests
[388/442] bitcoin: testing txvalidationcache_tests
[389/442] Running utility command for check-bitcoin-settings_tests
[390/442] Running utility command for check-bitcoin-txvalidationcache_tests
[391/442] bitcoin: testing timedata_tests
[392/442] bitcoin: testing scriptpubkeyman_tests
[393/442] bitcoin: testing streams_tests
[394/442] Running utility command for check-bitcoin-timedata_tests
[395/442] Running utility command for check-bitcoin-scriptpubkeyman_tests
[396/442] Running utility command for check-bitcoin-streams_tests
[397/442] bitcoin: testing uint256_tests
[398/442] Running utility command for check-bitcoin-uint256_tests
[399/442] bitcoin: testing wallet_tests
[400/442] bitcoin: testing script_standard_tests
[401/442] Running utility command for check-bitcoin-wallet_tests
[402/442] Running utility command for check-bitcoin-script_standard_tests
[403/442] bitcoin: testing serialize_tests
[404/442] Running utility command for check-bitcoin-serialize_tests
[405/442] bitcoin: testing blockcheck_tests
[406/442] Running utility command for check-pow-aserti32d_tests
[407/442] Running utility command for check-bitcoin-blockcheck_tests
[408/442] Running pow test suite
PASSED: pow test suite
[409/442] bitcoin: testing radix_tests
[410/442] Running utility command for check-seeder-message_writer_tests
[411/442] bitcoin: testing versionbits_tests
[412/442] bitcoin: testing getarg_tests
[413/442] Running utility command for check-seeder-p2p_messaging_tests
[414/442] Running utility command for check-bitcoin-versionbits_tests
[415/442] Running utility command for check-bitcoin-radix_tests
[416/442] Running utility command for check-bitcoin-getarg_tests
[417/442] bitcoin: testing schnorr_tests
[418/442] seeder: testing parse_name_tests
[419/442] Running utility command for check-bitcoin-schnorr_tests
[420/442] Running utility command for check-seeder-parse_name_tests
[421/442] Running seeder test suite
PASSED: seeder test suite
[422/442] bitcoin: testing transaction_tests
[423/442] Running utility command for check-bitcoin-transaction_tests
[424/442] bitcoin: testing monolith_opcodes_tests
[425/442] Linking CXX executable src/qt/test/test_bitcoin-qt
[426/442] bitcoin: testing validation_block_tests
[427/442] bitcoin: testing validation_tests
[428/442] bitcoin: testing crypto_tests
[429/442] Running utility command for check-bitcoin-monolith_opcodes_tests
[430/442] Running utility command for check-bitcoin-validation_block_tests
[431/442] Running utility command for check-bitcoin-validation_tests
[432/442] Running utility command for check-bitcoin-crypto_tests
[433/442] bitcoin: testing skiplist_tests
[434/442] Running utility command for check-bitcoin-skiplist_tests
[435/442] bitcoin: testing op_reversebytes_tests
[436/442] Running utility command for check-bitcoin-op_reversebytes_tests
[437/442] bitcoin-qt: testing test_bitcoin-qt
[438/442] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[439/442] bitcoin: testing coins_tests
[440/442] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Unrelated error, restarted the builds

This revision is now accepted and ready to land.Aug 13 2021, 19:41