Page MenuHomePhabricator
Differential D9882

refactor: allow constructing a valid CKey in place
ClosedPublic
Actions

Authored by majcosta on Aug 17 2021, 19:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC95c4a42ff4f0: refactor: allow constructing a valid CKey in place
Summary

allow constructing a valid CKey as syntactic sugar, less boilerplate on new code

did not change old code for now to avoid merge conflict nonsense for future backports

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 17 2021, 19:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2021, 19:05
majcosta requested review of this revision.Aug 17 2021, 19:05
Harbormaster completed remote builds in B16332: Diff 29424.Aug 17 2021, 19:42
deadalnix requested changes to this revision.Aug 18 2021, 16:34
deadalnix added a subscriber: deadalnix.

This is not very good because you are removing the function call, with an explicit name.

Make it a static method instead. And don't take a boolean as argument as par of the API, make that two functions. CKey::MakeNewCompressedKey() and CKey::MakeNewUncompressedKey() are much clearer.

This revision now requires changes to proceed.Aug 18 2021, 16:34
majcosta updated this revision to Diff 29432.Aug 18 2021, 20:16

went the factory route

majcosta updated this revision to Diff 29433.Aug 18 2021, 20:18

wtb newlines

Harbormaster completed remote builds in B16338: Diff 29432.Aug 18 2021, 20:34
Harbormaster completed remote builds in B16339: Diff 29433.Aug 18 2021, 20:40
deadalnix accepted this revision.Aug 19 2021, 12:55
This revision is now accepted and ready to land.Aug 19 2021, 12:55
Closed by commit rABC95c4a42ff4f0: refactor: allow constructing a valid CKey in place (authored by majcosta). · Explain WhyAug 19 2021, 18:26
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC95c4a42ff4f0: refactor: allow constructing a valid CKey in place.

Revision Contents
Changeset List

PathSize
src/
avalanche/
5 lines
test/
9 lines
5 lines
9 lines
7 lines
11 lines
3 lines
4 lines
14 lines

Diff 29439

View Options

src/avalanche/proofbuilder.cpp

Loading...
View Options

src/avalanche/test/delegation_tests.cpp

Loading...
View Options

src/avalanche/test/orphanproofpool_tests.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/avalanche/test/proof_tests.cpp

Loading...
View Options

src/avalanche/test/util.cpp

Loading...
View Options

src/key.h

Loading...
View Options

src/key.cpp

Loading...