Differential D9897

GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing
ClosedPublic
Actions

Authored by PiRK on Aug 23 2021, 07:29.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCd3b57ee3b225: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing

Summary

Commit 1:

GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing

GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing

Commit 2:

GUI: If BIP70 is disabled, give a proper error when trying to open a payment request file

https://github.com/bitcoin/bitcoin/pull/15063/commits/113f0004bec2dd203502f2a9bcba93676d5b9cda

This is a backport of core#15063

Test Plan

cmake .. -GNinja -DENABLE_BIP70=OFF
ninja all check-all`

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 23 2021, 07:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 23 2021, 07:29

PiRK requested review of this revision.Aug 23 2021, 07:29

teamcity edited the summary of this revision. (Show Details)Aug 23 2021, 07:30

Harbormaster completed remote builds in B16362: Diff 29465.Aug 23 2021, 07:42

majcosta accepted this revision.Aug 23 2021, 18:32

This revision is now accepted and ready to land.Aug 23 2021, 18:32

Closed by commit rABCd3b57ee3b225: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by PiRK). · Explain WhyAug 24 2021, 05:33

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd3b57ee3b225: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing.

Revision Contents
Changeset List

Path

Size

src/

qt/

paymentserver.cpp

28 lines

Diff 29504

View Options

GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsingClosedPublicActions