Page MenuHomePhabricator
Differential D9924

qt: Remove QFont warnings with QPA=minimal
ClosedPublic
Actions

Authored by PiRK on Aug 24 2021, 15:05.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC7569951bd3bf: qt: Remove QFont warnings with QPA=minimal
Summary

This is a backport of core#17908

Test Plan

Before this patch:

$ ./src/qt/test/test_bitcoin-qt | grep QFont | wc -l
~BitcoinApplication : Stopping thread
~BitcoinApplication : Stopped thread
17

After:

$ ./src/qt/test/test_bitcoin-qt | grep QFont | wc -l
~BitcoinApplication : Stopping thread
~BitcoinApplication : Stopped thread
0

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 24 2021, 15:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2021, 15:05
PiRK requested review of this revision.Aug 24 2021, 15:05
teamcity edited the summary of this revision. (Show Details)Aug 24 2021, 15:05
Harbormaster completed remote builds in B16397: Diff 29524.Aug 24 2021, 15:18
majcosta requested changes to this revision.Aug 24 2021, 16:09
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/qt/transactionview.cpp
460 ↗(On Diff #29524)

remove

This revision now requires changes to proceed.Aug 24 2021, 16:09
PiRK updated this revision to Diff 29535.Aug 24 2021, 16:29

remove conflict leftover line

majcosta accepted this revision.Aug 24 2021, 16:31
This revision is now accepted and ready to land.Aug 24 2021, 16:31
Harbormaster completed remote builds in B16400: Diff 29535.Aug 24 2021, 17:01
Closed by commit rABC7569951bd3bf: qt: Remove QFont warnings with QPA=minimal (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyAug 25 2021, 06:27
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7569951bd3bf: qt: Remove QFont warnings with QPA=minimal.

Revision Contents
Changeset List

PathSize
src/
qt/
8 lines
9 lines
4 lines
4 lines

Diff 29542

View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...
View Options

src/qt/transactionview.cpp

Loading...