Paths

Table of Contentst

Differential D9929

wallet: Fix for exported confirmation field in payment to self transactions
ClosedPublic
Actions

Authored by PiRK on Aug 25 2021, 07:19.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC075adcca138d: wallet: Fix for exported confirmation field in payment to self transactions

Summary

When exporting transactions as a CSV file, the "confirmed" column always showed True for transactions sent to self, even when not confirmed yet.
This fixes this bug.

This is a backport of core#14988

Test Plan

ninja && src/qt/bitcoin-qt

Send a transaction to yourself, export the transactions list as CSV before the new transaction is included in a block, and verify that it has "false" in the "Confirmed" column.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 25 2021, 07:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2021, 07:19

PiRK requested review of this revision.Aug 25 2021, 07:19

teamcity edited the summary of this revision. (Show Details)Aug 25 2021, 07:19

Harbormaster completed remote builds in B16406: Diff 29544.Aug 25 2021, 07:32

majcosta accepted this revision.Aug 25 2021, 08:52

This revision is now accepted and ready to land.Aug 25 2021, 08:52

Closed by commit rABC075adcca138d: wallet: Fix for exported confirmation field in payment to self transactions (authored by Ben Carman <benthecarman@live.com>, committed by PiRK). · Explain WhyAug 25 2021, 09:45

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC075adcca138d: wallet: Fix for exported confirmation field in payment to self transactions.

Revision Contents
Changeset List

Path

Size

src/

qt/

transactiontablemodel.cpp

4 lines

Diff 29552

src/qt/transactiontablemodel.cpp

Loading...