Page MenuHomePhabricator
Differential D9935

test: improve mempool_updatefromblock efficiency by using getmempoolentry for specific txns
ClosedPublic
Actions

Authored by PiRK on Aug 25 2021, 09:37.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCabd24602e018: test: improve mempool_updatefromblock efficiency by using getmempoolentry for…
Summary

This improvement shaves off almost one minute on my machine for one of the longest functional test.

Before:

$ testr.py mempool_updatefr*
Starting Bitcoin ABC functional tests

mempool_updatefromblock.py started
Running jobs: mempool_updatefromblock.py
mempool_updatefromblock.py passed, Duration: 277 s

After:

$ testr mempool_updatefr*
Starting Bitcoin ABC functional tests

mempool_updatefromblock.py started
Running jobs: mempool_updatefromblock.py
mempool_updatefromblock.py passed, Duration: 219 s

This is a single commit from core#22707. The other commits still have a year worth of unbackported dependencies, and have a lower impact.

https://github.com/bitcoin/bitcoin/pull/22707/commits/86dbd54ae8a8f9c693c0ea67114bbff24a0754df

Test Plan
test/functional/test_runner.py  mempool_updatefromblock

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 25 2021, 09:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2021, 09:37
PiRK requested review of this revision.Aug 25 2021, 09:37
teamcity edited the summary of this revision. (Show Details)Aug 25 2021, 09:37
PiRK edited the summary of this revision. (Show Details)Aug 25 2021, 09:38
Harbormaster completed remote builds in B16412: Diff 29550.Aug 25 2021, 09:47
PiRK planned changes to this revision.Aug 26 2021, 10:02

Standby until 22707 can be fully backported

PiRK edited the summary of this revision. (Show Details)Sep 1 2021, 07:15
PiRK requested review of this revision.Sep 1 2021, 07:18
Fabien accepted this revision.Sep 1 2021, 09:01
This revision is now accepted and ready to land.Sep 1 2021, 09:01
Closed by commit rABCabd24602e018: test: improve mempool_updatefromblock efficiency by using getmempoolentry for… (authored by Michael Dietz <michael.dietz@waya.ai>, committed by PiRK). · Explain WhySep 1 2021, 09:10
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCabd24602e018: test: improve mempool_updatefromblock efficiency by using getmempoolentry for….

Revision Contents
Changeset List

PathSize
test/
functional/
16 lines

Diff 29714

View Options

test/functional/mempool_updatefromblock.py

Loading...