Page MenuHomePhabricator

doc: Span pitfalls
ClosedPublic

Authored by PiRK on Aug 27 2021, 13:43.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC13597e2d22aa: doc: Span pitfalls
Summary

doc: Document Span pitfalls
doc: Mention Span in developer-notes.md

This is a backport of core#19367

Test Plan

Proofreading

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Aug 27 2021, 13:43
majcosta requested changes to this revision.Aug 27 2021, 20:49
majcosta added a subscriber: majcosta.
majcosta added inline comments.
doc/developer-notes.md
701–727 ↗(On Diff #29613)

this is from core#17134

728–729 ↗(On Diff #29613)

bit of a git leftover here :)

This revision now requires changes to proceed.Aug 27 2021, 20:49

fixed. I didn't review that second commit hard enough, it seems.

Tail of the build log:

[386/445] Running utility command for check-bitcoin-blockfilter_index_tests
[387/445] bitcoin: testing merkleblock_tests
[388/445] Running utility command for check-bitcoin-scheduler_tests
[389/445] Running utility command for check-bitcoin-merkleblock_tests
[390/445] bitcoin: testing sync_tests
[391/445] bitcoin: testing bip32_tests
[392/445] Running utility command for check-bitcoin-sync_tests
[393/445] bitcoin: testing torcontrol_tests
[394/445] Running utility command for check-bitcoin-bip32_tests
[395/445] Running utility command for check-bitcoin-torcontrol_tests
[396/445] bitcoin: testing txrequest_tests
[397/445] Running utility command for check-bitcoin-txrequest_tests
[398/445] bitcoin: testing settings_tests
[399/445] bitcoin: testing txvalidationcache_tests
[400/445] Running utility command for check-bitcoin-settings_tests
[401/445] bitcoin: testing timedata_tests
[402/445] Running utility command for check-bitcoin-txvalidationcache_tests
[403/445] bitcoin: testing streams_tests
[404/445] bitcoin: testing validation_flush_tests
[405/445] bitcoin: testing compilerbug_tests
[406/445] bitcoin: testing serialize_tests
[407/445] Running utility command for check-bitcoin-timedata_tests
[408/445] Running utility command for check-bitcoin-streams_tests
[409/445] Running utility command for check-bitcoin-validation_flush_tests
[410/445] Running utility command for check-bitcoin-serialize_tests
[411/445] Running utility command for check-bitcoin-compilerbug_tests
[412/445] bitcoin: testing blockcheck_tests
[413/445] Running utility command for check-bitcoin-blockcheck_tests
[414/445] bitcoin: testing radix_tests
[415/445] bitcoin: testing checkpoints_tests
[416/445] bitcoin: testing schnorr_tests
[417/445] Running utility command for check-bitcoin-radix_tests
[418/445] bitcoin: testing script_standard_tests
[419/445] Running utility command for check-bitcoin-schnorr_tests
[420/445] bitcoin: testing validationinterface_tests
[421/445] Running utility command for check-bitcoin-checkpoints_tests
[422/445] Running utility command for check-bitcoin-script_standard_tests
[423/445] Running utility command for check-bitcoin-validationinterface_tests
[424/445] bitcoin: testing blockstatus_tests
[425/445] Running utility command for check-bitcoin-blockstatus_tests
[426/445] bitcoin: testing op_reversebytes_tests
[427/445] bitcoin: testing wallet_tests
[428/445] Running utility command for check-bitcoin-op_reversebytes_tests
[429/445] Running utility command for check-bitcoin-wallet_tests
[430/445] bitcoin: testing cashaddr_tests
[431/445] Running utility command for check-bitcoin-cashaddr_tests
[432/445] bitcoin: testing script_tests
[433/445] Running utility command for check-bitcoin-script_tests
[434/445] bitcoin: testing crypto_tests
[435/445] bitcoin: testing util_tests
[436/445] bitcoin: testing versionbits_tests
[437/445] Running utility command for check-bitcoin-crypto_tests
[438/445] Running utility command for check-bitcoin-util_tests
[439/445] Running utility command for check-bitcoin-versionbits_tests
[440/445] bitcoin: testing monolith_opcodes_tests
[441/445] Running utility command for check-bitcoin-monolith_opcodes_tests
[442/445] bitcoin: testing coins_tests
[443/445] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
This revision is now accepted and ready to land.Aug 28 2021, 08:17
This revision was landed with ongoing or failed builds.Aug 30 2021, 06:29
This revision was automatically updated to reflect the committed changes.