Page MenuHomePhabricator
Create Task
Maniphest T187

Remove Consensus::Params parameter from ContextualCheckBlock
Closed, ResolvedPublic
Actions

Description

The function ContextualCheckBlock takes both a Config and a Consensus::Params as parameter. The second one can be accessed from the config and is therefore redundant.

Revisions and Commits

rABC Bitcoin ABC
ClosedD1028 Remove Consensus::Params parameter from ContextualCheckBlock

Related Objects

Event Timeline

jasonbcox created this task.Jan 22 2018, 04:48
matiu added a subscriber: matiu.Jan 23 2018, 15:06

Checking ContextualCheckBlock at https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/src/validation.cpp;2c81a03ad212b73ca7002ef9f9f891a025c1f6bd$3523

I don't see CChainParams is been passed.

jasonbcox renamed this task from Remove CChainParams parameter from ContextualCheckBlock to Remove Consensus::Params parameter from ContextualCheckBlock.Jan 23 2018, 17:58
jasonbcox updated the task description. (Show Details)

Fixed the task title and descrition. It wasn't CChainParams directly, but rather a subcomponent of that, which is Consensus::Params. Look at calls to ContextualCheckBlock and it will be clear that the "params" parameter is redundant. Thanks for taking a look at this. :)

matiu claimed this task.Jan 23 2018, 19:24

ok, on it.

matiu added a revision: D1028: Remove Consensus::Params parameter from ContextualCheckBlock.Jan 23 2018, 21:03
matiu mentioned this in D1028: Remove Consensus::Params parameter from ContextualCheckBlock.Jan 23 2018, 21:04
matiu mentioned this in rABC6ef41ed3a922: Remove Consensus::Params parameter from ContextualCheckBlock.Jan 23 2018, 21:47
matiu closed this task as Resolved.Jan 24 2018, 02:32

At D1028

matiu mentioned this in rSTAGING6ef41ed3a922: Remove Consensus::Params parameter from ContextualCheckBlock.Mar 1 2018, 23:44