Page MenuHomePhabricator

matiu (Matias Alejo Garcia)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2017, 15:46 (55 w, 2 d)

Recent Activity

Mon, Nov 19

Herald added a reviewer for D2095: update IsValidSignatureEncoding doc: Restricted Project.
Mon, Nov 19, 05:10

Sep 27 2018

matiu committed rSTAGINGab6d047dfe77: Remove GetConfig call from LoadBlockIndexGuts (authored by matiu).
Remove GetConfig call from LoadBlockIndexGuts
Sep 27 2018, 18:53
matiu committed rSTAGINGe68bd2e95075: Remove unnecesary Boost (authored by matiu).
Remove unnecesary Boost
Sep 27 2018, 18:50
matiu committed rSTAGINGd3fab49e71b8: Fixes `--enable-asan` compilation in MacOS (authored by matiu).
Fixes `--enable-asan` compilation in MacOS
Sep 27 2018, 18:49
matiu committed rSTAGING27174fca6119: update ubuntu hash for gitian (authored by matiu).
update ubuntu hash for gitian
Sep 27 2018, 18:49
matiu committed rSTAGING2077a44d5cf6: Better error message from ParseScript (authored by matiu).
Better error message from ParseScript
Sep 27 2018, 18:49
matiu committed rSTAGING22d0c8b3a2d9: fix ubsan for rpc method calling (authored by matiu).
fix ubsan for rpc method calling
Sep 27 2018, 18:47

Jul 3 2018

matiu updated the diff for D1525: partial gArgs refactor.

rebased

Jul 3 2018, 12:22

Jul 2 2018

matiu updated the diff for D1525: partial gArgs refactor.

Adds PersistMempoolSet and StopAfterBlockImport flags to refactor

Jul 2 2018, 18:45
matiu added a comment to D1525: partial gArgs refactor.

The idea might be to start moving away from the GetArg() stuff all over the codebase, and instead validate and set proper config variables at launch.

Jul 2 2018, 17:37

Jun 30 2018

matiu abandoned D1509: WIP: Remove GetConfig/Params call from dstencode.

Closed in favor of the work started at https://reviews.bitcoinabc.org/D1525

Jun 30 2018, 21:13
Herald added a reviewer for D1525: partial gArgs refactor: Restricted Project.
Jun 30 2018, 21:12

Jun 27 2018

matiu added a comment to D1509: WIP: Remove GetConfig/Params call from dstencode.

@deadalnix @jasonbcox adding config param to many method's signatures doesn't feel right. If we include gArgs + ChainParams + ChainBaseParams to config it will lose meaning, you will end up not understanding what the method needs.

Jun 27 2018, 17:28

Jun 19 2018

matiu retitled D1509: WIP: Remove GetConfig/Params call from dstencode from Remove GetConfig/Params call from dstencode to WIP: Remove GetConfig/Params call from dstencode.
Jun 19 2018, 18:02
Herald added a reviewer for D1509: WIP: Remove GetConfig/Params call from dstencode: Restricted Project.
Jun 19 2018, 17:24
matiu committed rABCab6d047dfe77: Remove GetConfig call from LoadBlockIndexGuts (authored by matiu).
Remove GetConfig call from LoadBlockIndexGuts
Jun 19 2018, 01:37
matiu closed D1508: Remove GetConfig call from LoadBlockIndexGuts.
Jun 19 2018, 01:37
matiu updated the diff for D1508: Remove GetConfig call from LoadBlockIndexGuts.

Move class def to top.

Jun 19 2018, 00:59

Jun 18 2018

Herald added a reviewer for D1508: Remove GetConfig call from LoadBlockIndexGuts: Restricted Project.
Jun 18 2018, 21:23
matiu added a comment to D1470: Add gitian-sigs path and description to use it.

We had discussed out of band that you were going to fix the "Readme.md" file to be a proper MD file. I am requesting those changes here.

Jun 18 2018, 20:35
matiu updated the diff for D1470: Add gitian-sigs path and description to use it.

Update format of Readme.md to match MarkDown

Jun 18 2018, 20:34

Jun 12 2018

matiu added inline comments to D1110: Add UTXO commitment contruction from UTXO cursor.
Jun 12 2018, 17:54
matiu added inline comments to D1441: Add logging for block header receive time.
Jun 12 2018, 14:28

Jun 11 2018

matiu added a parent revision for D1495: Add unit tests for combining UTXO commitments.: D1074: Add Utxo Commitment wrapper around libsecp256k1.
Jun 11 2018, 16:38
matiu added a child revision for D1074: Add Utxo Commitment wrapper around libsecp256k1: D1495: Add unit tests for combining UTXO commitments..
Jun 11 2018, 16:38

Jun 4 2018

matiu updated the diff for D1470: Add gitian-sigs path and description to use it.

update doc $USER variable

Jun 4 2018, 17:24

May 31 2018

matiu added a comment to D1470: Add gitian-sigs path and description to use it.

I don't think it makes a lot of sens to have this under source control.

May 31 2018, 16:08

May 30 2018

matiu accepted D1465: Added my release key.
May 30 2018, 16:31
matiu updated the diff for D1470: Add gitian-sigs path and description to use it.

Add osx builds asserts + sig

May 30 2018, 03:17
Herald added a reviewer for D1470: Add gitian-sigs path and description to use it: Restricted Project.
May 30 2018, 03:01

May 29 2018

matiu requested changes to D1465: Added my release key.

Please armor key (send the .asc) file. Thanks for your comment on the doc, I have updated it.

May 29 2018, 01:49

May 28 2018

matiu accepted D1459: Add braces around various control flows in validation.cpp.
May 28 2018, 14:58

May 22 2018

matiu accepted D1435: Reformat some of the doc comments in validation.h.
May 22 2018, 13:28
matiu accepted D1434: Fix a warning in policyestimator_tests.cpp.
May 22 2018, 13:27
matiu committed rABCe68bd2e95075: Remove unnecesary Boost (authored by matiu).
Remove unnecesary Boost
May 22 2018, 12:17
matiu closed D1432: Remove unnecesary Boost.
May 22 2018, 12:17
Herald added a reviewer for D1432: Remove unnecesary Boost: Restricted Project.
May 22 2018, 11:36

May 21 2018

matiu committed rABCd3fab49e71b8: Fixes `--enable-asan` compilation in MacOS (authored by matiu).
Fixes `--enable-asan` compilation in MacOS
May 21 2018, 06:29
matiu closed D1407: Fixes `--enable-asan` compilation in MacOS.
May 21 2018, 06:28
matiu committed rABC2077a44d5cf6: Better error message from ParseScript (authored by matiu).
Better error message from ParseScript
May 21 2018, 06:28
matiu closed D1429: Better error message from ParseScript.
May 21 2018, 06:27
matiu committed rABC27174fca6119: update ubuntu hash for gitian (authored by matiu).
update ubuntu hash for gitian
May 21 2018, 06:27
matiu closed D1430: update ubuntu hash for gitian.
May 21 2018, 06:27

May 17 2018

Herald added a reviewer for D1430: update ubuntu hash for gitian: Restricted Project.
May 17 2018, 15:37
Herald added a reviewer for D1429: Better error message from ParseScript: Restricted Project.
May 17 2018, 15:30

May 10 2018

matiu updated the diff for D1407: Fixes `--enable-asan` compilation in MacOS.

More LIBTOOL_APP_LDFLAGS config to a more appropiate place

May 10 2018, 18:45

May 9 2018

Herald added a reviewer for D1407: Fixes `--enable-asan` compilation in MacOS: Restricted Project.
May 9 2018, 20:10
matiu accepted D1401: Update policyestimator_tests to use COutPoint's accessor..
May 9 2018, 12:34
matiu accepted D1389: Update Coin code to use COutPoint via constructor/accessor.
May 9 2018, 12:32
matiu accepted D1399: Update various tests to use COutPoint's accessors.
May 9 2018, 02:56
matiu accepted D1398: Use COutPoint's accessors in the network code.
May 9 2018, 02:30
matiu accepted D1397: Use COutPoint's accessor in the txdb code.
May 9 2018, 02:28
matiu accepted D1396: Use COutPoint's accessors in validation code and tests..
May 9 2018, 02:26
matiu accepted D1394: Use COutPoint in the mempool code.
May 9 2018, 02:24
matiu accepted D1395: Update script code to use COutPoint's accessor.
May 9 2018, 02:19
matiu accepted D1388: Add accessors for transaction id and n in COutPoint.
May 9 2018, 01:20
matiu accepted D1392: Move RPC code to use COutPoint accessors.
May 9 2018, 01:18

May 8 2018

matiu accepted D1382: Use TxId in miner_tests.cpp.
May 8 2018, 15:54
matiu accepted D1384: Remove dead constant.
May 8 2018, 15:49

May 5 2018

matiu committed rABC22d0c8b3a2d9: fix ubsan for rpc method calling (authored by matiu).
fix ubsan for rpc method calling
May 5 2018, 18:53
matiu closed D1371: fix ubsan for rpc method calling.
May 5 2018, 18:53
matiu updated the diff for D1371: fix ubsan for rpc method calling.

rebased

May 5 2018, 18:28
matiu updated the diff for D1371: fix ubsan for rpc method calling.

use C++ initializer

May 5 2018, 18:09
matiu updated the diff for D1371: fix ubsan for rpc method calling.

comments and formatting nits

May 5 2018, 17:53
matiu added a comment to D1371: fix ubsan for rpc method calling.

updated std::set. Thanks for the review.

May 5 2018, 12:29
matiu updated the diff for D1371: fix ubsan for rpc method calling.

Better std:set for rpc help

May 5 2018, 12:28

May 4 2018

matiu updated the diff for D1371: fix ubsan for rpc method calling.

update comments

May 4 2018, 21:55
matiu added inline comments to D1371: fix ubsan for rpc method calling.
May 4 2018, 21:53
matiu retitled D1371: fix ubsan for rpc method calling from WIP:fix ubsan for rpc method calling to fix ubsan for rpc method calling.
May 4 2018, 21:51
matiu updated the diff for D1371: fix ubsan for rpc method calling.

refactor CRPCCommand

May 4 2018, 21:50
matiu added a comment to D1371: fix ubsan for rpc method calling.

As background, I was able to reproduce the reported problem with:

class C {
    public:
        int a;
};
May 4 2018, 17:54
matiu updated the diff for D1371: fix ubsan for rpc method calling.

revert abc.cpp

May 4 2018, 17:49
Herald added a reviewer for D1371: fix ubsan for rpc method calling: Restricted Project.
May 4 2018, 17:46

Apr 19 2018

matiu added a comment to D1298: Update developer notes and link to it from contributing docs.

LGTM

Apr 19 2018, 13:08

Apr 18 2018

matiu added a comment to D1293: Add basic sanity checking for script pushdata size.

ACK

Apr 18 2018, 23:17

Apr 11 2018

matiu accepted D1275: [cmake] Compile everything with visibility hidden.

Should we set VISIBILITY_INLINES_HIDDENalso?

Apr 11 2018, 08:21
matiu added a comment to D1276: Refactor logging code into a global object.

Nice! ConceptACK. Initial code review looks fine.

Apr 11 2018, 08:18

Apr 9 2018

matiu created T317: Add address indexes.
Apr 9 2018, 13:13

Apr 8 2018

matiu accepted D1255: [secp256k1] Reduce usage of hardcoded size constant.

Nice refactor with 'buffer_append', much clear now.

Apr 8 2018, 14:47
matiu accepted D1254: rename Bitcoin to Bitcoin Cash for UI.
Apr 8 2018, 14:40

Apr 4 2018

matiu added a comment to D1226: Cleanup unneeded #define in net.cpp.

well done Jason!

Apr 4 2018, 20:46
matiu accepted D1239: ignore OSX make deploy generate files.
Apr 4 2018, 13:41

Apr 3 2018

matiu accepted D1242: Add fallback install build for libdmg and cdrkit.
Apr 3 2018, 18:26
matiu accepted D1238: Update version for cmake as well..
Apr 3 2018, 11:48

Apr 2 2018

matiu added inline comments to D1224: Added developer-notes for debugging unit tests with GDB.
Apr 2 2018, 16:53

Mar 16 2018

matiu added a comment to D1206: Update release files for 0.17.0.

left some minor comments.

Mar 16 2018, 18:04
matiu updated the diff for D1204: WIP: add OP_RETURN largeData (220bytes) activation code + test.

fix large test, leave the test failing waiting for the activation code to be completed

Mar 16 2018, 10:28
matiu retitled D1204: WIP: add OP_RETURN largeData (220bytes) activation code + test from add OP_RETURN largeData (220bytes) activation code + test (WIP) to WIP: add OP_RETURN largeData (220bytes) activation code + test.
Mar 16 2018, 10:05
Herald added a reviewer for D1204: WIP: add OP_RETURN largeData (220bytes) activation code + test: Restricted Project.
Mar 16 2018, 10:05
matiu added a child revision for D1158: Add a flag that update default datacarriersize to 220 byte: D1204: WIP: add OP_RETURN largeData (220bytes) activation code + test.
Mar 16 2018, 10:05
matiu accepted D1158: Add a flag that update default datacarriersize to 220 byte.

ACK!

Mar 16 2018, 00:26
matiu accepted D1203: Various nits in policy.cpp.
Mar 16 2018, 00:17

Mar 14 2018

matiu added a comment to D1158: Add a flag that update default datacarriersize to 220 byte.

Left some questions, thanks!

Mar 14 2018, 19:15

Mar 12 2018

matiu accepted D1191: Various nits in sighash_tests.cpp.
Mar 12 2018, 18:59

Mar 1 2018

matiu committed rSTAGING349dd3488ac8: TestNode tidyups (authored by John Newbery <john@johnnewbery.com>).
TestNode tidyups
Mar 1 2018, 23:47
matiu committed rSTAGING17d4ca0d2a31: qa: Move wait_until to util (authored by MarcoFalke <falke.marco@gmail.com>).
qa: Move wait_until to util
Mar 1 2018, 23:47
matiu committed rSTAGINGbdb7e995560d: Add bitcoin-cli -stdin and -stdinrpcpass + tests (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
Add bitcoin-cli -stdin and -stdinrpcpass + tests
Mar 1 2018, 23:47
matiu committed rSTAGING23870542d3b4: qa: Add multiwallet prefix test (authored by MarcoFalke <falke.marco@gmail.com>).
qa: Add multiwallet prefix test
Mar 1 2018, 23:47
matiu added a commit to T177: Backport Core PR11743: qa: Add multiwallet prefix test: rSTAGING23870542d3b4: qa: Add multiwallet prefix test.
Mar 1 2018, 23:46
matiu committed rSTAGINGeab58826a7ed: Summary: stop using the gArgs wrappers (authored by Marko Bencun <marko.bencun@monetas.net>).
Summary: stop using the gArgs wrappers
Mar 1 2018, 23:46