Diffusion Bitcoin ABC staging eab58826a7ed

Summary: stop using the gArgs wrappers
eab58826a7ed
Actions

Tags

None

Subscribers

None

Description

Summary: stop using the gArgs wrappers

Summary:

Scripted diff, checked manually:

find src/ -name "*.cpp" ! -wholename "src/util.h" ! -wholename "src/util.cpp" | xargs perl -i -pe 's/(?<!\.)(ParseParameters|ReadConfigFile|IsArgSet|(Soft|Force)?(Get|Set)(|Bool|)Arg(s)?)\(/gArgs.\1(/g'

remove unused gArgs wrappers

Backport from Core's https://github.com/bitcoin/bitcoin/commit/c2704ec98a1b7b35b6a7c1b6b26a3f16d44e8880

Fixes T212

Test Plan:

make check && test/functional/test_runner.py

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix, teamcity

Maniphest Tasks: T212

Differential Revision: https://reviews.bitcoinabc.org/D1044

Details

Provenance

Marko Bencun <marko.bencun@monetas.net>	Authored on Jun 15 2017, 20:45
matiu	Committed on Jan 30 2018, 23:07
matiu	Pushed on Jan 30 2018, 23:11

Reviewer

Restricted Project

Differential Revision

D1044: Summary: stop using the gArgs wrappers

Parents

rSTAGINGb9120934cd6c: fix multiwallet / symlink check

Branches

Unknown

Tags

Unknown

References

tag: phabricator/base/2775, tag: phabricator/base/2772, tag: phabricator/base/2771

Tasks

T212: scripted-diff: stop using the gArgs wrappers

Event Timeline

matiu added a task: T212: scripted-diff: stop using the gArgs wrappers.Mar 1 2018, 23:46

matiu committed rSTAGINGeab58826a7ed: Summary: stop using the gArgs wrappers (authored by Marko Bencun <marko.bencun@monetas.net>).Jan 30 2018, 23:07

Changes (44)

Path

Size

src/

bitcoin-cli.cpp

chainparamsbase.cpp

net_processing.cpp

policy/

qt/

optionsmodel.cpp

paymentrequestplus.cpp

paymentserver.cpp

test/

rpcnestedtests.cpp

utilitydialog.cpp

walletmodel.cpp

rpc/

script/

scriptcache.cpp

test/

getarg_tests.cpp

miner_tests.cpp

test_bitcoin.cpp

wallet/

zmq/

zmqnotificationinterface.cpp

rSTAGINGeab58826a7ed

src/bitcoin-cli.cpp

Loading...

src/bitcoin-tx.cpp

Loading...

src/bitcoind.cpp

Loading...

src/chainparamsbase.cpp

Loading...

src/dbwrapper.cpp

Loading...

src/httprpc.cpp

Loading...

src/httpserver.cpp

Loading...

src/init.cpp

Loading...

src/miner.cpp

Loading...

src/net.cpp

Loading...

src/net_processing.cpp

Loading...

src/policy/fees.cpp

Loading...

src/qt/bitcoin.cpp

Loading...

src/qt/guiutil.cpp

Loading...

src/qt/intro.cpp

Loading...

src/qt/optionsmodel.cpp

Loading...

src/qt/paymentrequestplus.cpp

Loading...

src/qt/paymentserver.cpp

Loading...

src/qt/test/rpcnestedtests.cpp

Loading...

src/qt/utilitydialog.cpp

Loading...

src/qt/walletmodel.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/rpc/protocol.cpp

Loading...

src/script/scriptcache.cpp

Loading...

src/script/sigcache.cpp

Loading...

src/test/DoS_tests.cpp

Loading...

src/test/getarg_tests.cpp

Loading...

src/test/miner_tests.cpp

Loading...

src/test/net_tests.cpp

Loading...

src/test/test_bitcoin.cpp

Loading...

src/timedata.cpp

Loading...

src/torcontrol.cpp

Loading...

src/txdb.cpp

Loading...

src/util.cpp

Loading...

src/util.h

Loading...

src/validation.cpp

Loading...

src/wallet/db.cpp

Loading...

src/wallet/rpcdump.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/wallet.cpp

Loading...

src/wallet/walletdb.cpp

Loading...

src/warnings.cpp

Loading...

src/zmq/zmqnotificationinterface.cpp

Loading...