Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

T212: scripted-diff: stop using the gArgs wrappers

Commits

rSTAGINGeab58826a7ed: Summary: stop using the gArgs wrappers
rABCeab58826a7ed: Summary: stop using the gArgs wrappers

Summary

Scripted diff, checked manually:

remove unused gArgs wrappers

Backport from Core's https://github.com/bitcoin/bitcoin/commit/c2704ec98a1b7b35b6a7c1b6b26a3f16d44e8880

Fixes T212

Test Plan

make check && test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

matiu created this revision.Jan 30 2018, 16:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2018, 16:32

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

matiu retitled this revision from Summary: stop using the gArgs wrappers to Summary: stop using the gArgs wrappers.Jan 30 2018, 16:44

matiu edited the summary of this revision. (Show Details)

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Trying to rerun tests

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

This seems alright, please make sure the tests are passing before landing.

This revision is now accepted and ready to land.Jan 30 2018, 21:45

deadalnix added inline comments.Jan 30 2018, 21:46

test/functional/multiwallet.py
14 ↗	(On Diff #2755)	Revert.

rebased

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Revert change to trigger tests

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Closed by commit rABCeab58826a7ed: Summary: stop using the gArgs wrappers (authored by Marko Bencun <marko.bencun@monetas.net>, committed by matiu). · Explain WhyJan 30 2018, 23:08

This revision was automatically updated to reflect the committed changes.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Summary: stop using the gArgs wrappersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2770

src/bitcoin-cli.cpp

src/bitcoin-tx.cpp

src/bitcoind.cpp

src/chainparamsbase.cpp

src/dbwrapper.cpp

src/httprpc.cpp

src/httpserver.cpp

src/init.cpp

src/miner.cpp

src/net.cpp

src/net_processing.cpp

src/policy/fees.cpp

src/qt/bitcoin.cpp

src/qt/guiutil.cpp

src/qt/intro.cpp

src/qt/optionsmodel.cpp

src/qt/paymentrequestplus.cpp

src/qt/paymentserver.cpp

src/qt/test/rpcnestedtests.cpp

src/qt/utilitydialog.cpp

src/qt/walletmodel.cpp

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/rpc/protocol.cpp

src/script/scriptcache.cpp

src/script/sigcache.cpp

src/test/DoS_tests.cpp

src/test/getarg_tests.cpp

src/test/miner_tests.cpp

src/test/net_tests.cpp

src/test/test_bitcoin.cpp

src/timedata.cpp

src/torcontrol.cpp

src/txdb.cpp

src/util.h

src/util.cpp

src/validation.cpp

src/wallet/db.cpp

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

src/wallet/wallet.cpp

src/wallet/walletdb.cpp

src/warnings.cpp

src/zmq/zmqnotificationinterface.cpp

Summary: stop using the gArgs wrappers
ClosedPublic
Actions

Revision Contents
Changeset List