Page MenuHomePhabricator

Cleanup unneeded #define in net.cpp
ClosedPublic

Authored by jasonbcox on Mar 30 2018, 06:42.

Details

Summary

This code gives a bad smell. If we're going to adopt something like this, we should rename the macro to something sane and start using it everywhere. Otherwise, it just looks like lazy programming.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mar 30 2018, 06:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2018, 06:42
deadalnix accepted this revision.Mar 30 2018, 15:11
This revision is now accepted and ready to land.Mar 30 2018, 15:11
This revision was automatically updated to reflect the committed changes.
matiu added a subscriber: matiu.Apr 4 2018, 20:46

well done Jason!