Remove GetConfig call from LoadBlockIndexGuts
ClosedPublic
Actions

Authored by matiu on Jun 18 2018, 21:23.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGab6d047dfe77: Remove GetConfig call from LoadBlockIndexGuts
rABCab6d047dfe77: Remove GetConfig call from LoadBlockIndexGuts

Summary

As per title

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

matiu created this revision.Jun 18 2018, 21:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 18 2018, 21:23

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2753: Diff 4140.Jun 18 2018, 21:58

likestamp

This revision is now accepted and ready to land.Jun 18 2018, 23:56

deadalnix added inline comments.Jun 18 2018, 23:56

src/txdb.h
20 ↗	(On Diff #4140)	Here.
64 ↗	(On Diff #4140)	Maybe put that on top.

Move class def to top.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2754: Diff 4145.Jun 19 2018, 01:34

Closed by commit rABCab6d047dfe77: Remove GetConfig call from LoadBlockIndexGuts (authored by matiu). · Explain WhyJun 19 2018, 01:37

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

2 lines

2 lines

3 lines

2 lines

8 lines

Diff 4146

View Options

src/init.cpp

View Options

src/txdb.h

View Options

src/txdb.cpp

View Options

src/validation.h

View Options

Remove GetConfig call from LoadBlockIndexGutsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4146

src/init.cpp

src/txdb.h

src/txdb.cpp

src/validation.h

src/validation.cpp

Remove GetConfig call from LoadBlockIndexGuts
ClosedPublic
Actions

Revision Contents
Changeset List