Page MenuHomePhabricator
Differential D1508

Remove GetConfig call from LoadBlockIndexGuts
ClosedPublic
Actions

Authored by matiu on Jun 18 2018, 21:23.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGab6d047dfe77: Remove GetConfig call from LoadBlockIndexGuts
rABCab6d047dfe77: Remove GetConfig call from LoadBlockIndexGuts
Summary

As per title

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2754
Build 3619: Bitcoin ABC Buildbot (legacy)
Build 3618: arc lint + arc unit

Event Timeline

matiu created this revision.Jun 18 2018, 21:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 18 2018, 21:23
teamcity added a subscriber: teamcity.Jun 18 2018, 21:25

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 18 2018, 21:58

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2753: Diff 4140.Jun 18 2018, 21:58
deadalnix accepted this revision.Jun 18 2018, 23:56
deadalnix added a subscriber: deadalnix.

likestamp

This revision is now accepted and ready to land.Jun 18 2018, 23:56
deadalnix added inline comments.Jun 18 2018, 23:56
src/txdb.h
20 ↗(On Diff #4140)

Here.

64 ↗(On Diff #4140)

Maybe put that on top.

matiu updated this revision to Diff 4145.Jun 19 2018, 00:59

Move class def to top.

teamcity added a comment.Jun 19 2018, 01:01

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 19 2018, 01:34

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2754: Diff 4145.Jun 19 2018, 01:34
Closed by commit rABCab6d047dfe77: Remove GetConfig call from LoadBlockIndexGuts (authored by matiu). · Explain WhyJun 19 2018, 01:37
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
2 lines
3 lines
2 lines
8 lines

Diff 4145

View Options

src/init.cpp

Loading...
View Options

src/txdb.h

Loading...
View Options

src/txdb.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...