ignore OSX make deploy generate files
AbandonedPublic
Actions

Authored by andychen on Apr 3 2018, 12:20.

Details

Reviewers

jasonbcox
matiu
deadalnix

Group Reviewers

Restricted Project
Restricted Owners Package	(Owns No Changed Paths)

Summary

OSX make deploy generate files which should be ignored

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

feature/ignore_osx_make_deploy_files

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2231
Build 2605: Bitcoin ABC Buildbot (legacy)
Build 2604: arc lint + arc unit

Event Timeline

andychen created this revision.Apr 3 2018, 12:20

Owners added a reviewer: Restricted Owners Package.Apr 3 2018, 12:20

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptApr 3 2018, 12:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2231: Diff 3380.Apr 3 2018, 12:54

matiu accepted this revision as: matiu.Apr 4 2018, 13:41

deadalnix requested changes to this revision.Apr 4 2018, 21:40

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

.gitignore
80	Remove irrelevent files.
95	What happens with core on these ? Do they generate them ? If not why ?

This revision now requires changes to proceed.Apr 4 2018, 21:40

andychen added inline comments.Apr 5 2018, 04:51

.gitignore
80	which irrelevent files?
95	make deploy on OSX generate these files which I think should be ignored

You should be building out of tree rather than in the same repo to avoid us having to maintain a long list of generated files to ignore. Please either fix up this diff or abandon, as I'd like to cleanup our review board.

andychen abandoned this revision.Sep 21 2018, 01:11

Revision Contents
Changeset List

Path

Size

.gitignore

5 lines

Diff 3380

View Options

ignore OSX make deploy generate filesAbandonedPublicActions