Ensure pushdata size are enforced by ParseScript
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	deadalnix
	Apr 16 2018, 21:52

Description

ParseScript accept malformed scripts that push an invalid amount of data.

Notably the following is not checked at this point in time:

That data is actually pushed when a push is expected.
That push using OP_PUSHDATA1, OP_PUSHDATA2 and OP_PUSHDATA4 are actually the proper size.
That no data is pushed when no push is expected.

D1293 updates it to do basic checking on the data being pushed, but do not quite check everything it should. However it can be used as a model to resolve this task.

Related Objects

Mentioned In: rSTAGINGd0fb55cdf701: Ensure checks are enforced in core_read.cpp for all push types
rSTAGINGbfde70fb948d: Add basic sanity checking for script pushdata size
rABCd0fb55cdf701: Ensure checks are enforced in core_read.cpp for all push types
rABCbfde70fb948d: Add basic sanity checking for script pushdata size
D1295: Ensure checks are enforced in core_read.cpp for all push types
D1293: Add basic sanity checking for script pushdata size
Mentioned Here: D1293: Add basic sanity checking for script pushdata size

Event Timeline

deadalnix triaged this task as High priority.Apr 16 2018, 21:52

deadalnix created this task.

I'm not sure how you're supposed to check:

* That no data is pushed when no push is expected.

and

That data is actually pushed when a push is expected.

schancel mentioned this in D1293: Add basic sanity checking for script pushdata size.Apr 17 2018, 23:38

schancel mentioned this in D1295: Ensure checks are enforced in core_read.cpp for all push types.

schancel claimed this task.Apr 18 2018, 19:21

deadalnix mentioned this in rABCbfde70fb948d: Add basic sanity checking for script pushdata size.Apr 18 2018, 23:24

schancel mentioned this in rABCd0fb55cdf701: Ensure checks are enforced in core_read.cpp for all push types.May 2 2018, 22:34

schancel closed this task as Resolved.Jun 5 2018, 00:23

deadalnix mentioned this in rSTAGINGbfde70fb948d: Add basic sanity checking for script pushdata size.Sep 27 2018, 18:44

schancel mentioned this in rSTAGINGd0fb55cdf701: Ensure checks are enforced in core_read.cpp for all push types.Sep 27 2018, 18:47

Ensure pushdata size are enforced by ParseScriptClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Ensure pushdata size are enforced by ParseScript
Closed, ResolvedPublic
Actions