Page MenuHomePhabricator

Clean up Zombie GetBlockFileInfo function
Closed, WontfixPublic

Description

GetBlockFileInfo() is defined in validation.h, but only used once in wallet/test/wallet_tests.cpp:456. Appears to be the remnants of previous refactors and can be replaced inline.

Event Timeline

nakihito created this task.Jul 22 2018, 22:20
nakihito triaged this task as Low priority.

The function uses the global variable vinfoBlockFile, however, this function is locked away in an anonymous namespace. I'm not sure this change is actually worth making at this point as it would require either naming the namespace or moving the the variable outside of the namespace.

nakihito closed this task as Wontfix.Tue, Mar 5, 20:58