Use size_t for stack index in OP_MULTISIG
ClosedPublic
Actions

Authored by deadalnix on Jul 11 2019, 01:26.

Details

Reviewers

markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGING655416f9d8cd: Use size_t for stack index in OP_MULTISIG
rABC655416f9d8cd: Use size_t for stack index in OP_MULTISIG

Summary

Indices are used to index into the stack and to be compared with the stack size. Even though we don't expect the stack to a billions of elements big, it is correct to use size_t here.

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

size_tmultisig

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6817
Build 11681: Bitcoin ABC Buildbot (legacy)
Build 11680: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 11 2019, 01:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2019, 01:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6817: Diff 10224.Jul 11 2019, 01:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg added a subscriber: markblundeberg.Jul 11 2019, 02:00

markblundeberg added inline comments.

src/script/interpreter.cpp
1013	Should `k` also be a size_t? I had to dig through some C++ standards to convince myself why `stacktop(-isig - k)` works now, when `isig` is size_t and `k` is an int...