Page MenuHomePhabricator
Differential D3657

Merge #12298: Refactor HaveKeys to early return on false result
ClosedPublic
Actions

Authored by jasonbcox on Jul 11 2019, 21:28.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING4e467915935e: Merge #12298: Refactor HaveKeys to early return on false result
rABC4e467915935e: Merge #12298: Refactor HaveKeys to early return on false result
Summary

5bdbbdc Refactor HaveKeys to early return on false result (João Barbosa)

Pull request description:

This consists in a trivial change where the return type of `HaveKeys()` is now `bool` meaning that it returns whether all keys are in the keystore, and early returns when one isn't.

Tree-SHA512: 03e35ea8486404b84884b49f6905c9f4fc161a3eeef080b06482d77985d5242a2bdd57a34b8d16abe19ee8c6cfa3e6fbcb935c73197d53f4cd468a2c7c0b889b

Backport of Core PR12298

https://github.com/bitcoin/bitcoin/pull/12298/files

Test Plan
make check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12298
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6831
Build 11709: Bitcoin ABC Buildbot (legacy)
Build 11708: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 11 2019, 21:28
Herald added a reviewer: deadalnix. · View Herald TranscriptJul 11 2019, 21:28
teamcity added a comment.Jul 11 2019, 21:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 11 2019, 21:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6831: Diff 10252!Jul 11 2019, 21:30
deadalnix accepted this revision.Jul 12 2019, 12:23
This revision is now accepted and ready to land.Jul 12 2019, 12:23
teamcity added a comment.Jul 12 2019, 17:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6831: Diff 10252.Jul 12 2019, 17:14
teamcity added a comment.Jul 12 2019, 17:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.Jul 12 2019, 19:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2019, 19:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC4e467915935e: Merge #12298: Refactor HaveKeys to early return on false result (authored by jasonbcox). · Explain WhyJul 16 2019, 02:11
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC4e467915935e: Merge #12298: Refactor HaveKeys to early return on false result.
jasonbcox added a commit: rSTAGING4e467915935e: Merge #12298: Refactor HaveKeys to early return on false result.Sep 19 2019, 01:17

Revision Contents
Changeset List

PathSize
src/
script/
14 lines

Diff 10252

View Options

src/script/ismine.cpp

Loading...