Differential D3678

Nits in Qt test
ClosedPublic
Actions

Authored by deadalnix on Jul 16 2019, 13:21.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGb4bccba1f5f3: Nits in Qt test
rABCb4bccba1f5f3: Nits in Qt test

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

qttestits

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6866
Build 11779: Bitcoin ABC Buildbot (legacy)
Build 11778: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 16 2019, 13:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2019, 13:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6866: Diff 10315.Jul 16 2019, 13:28

jasonbcox requested changes to this revision.Jul 16 2019, 14:50

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/qt/test/util.h
10	Add this entry to the spell check linter.

This revision now requires changes to proceed.Jul 16 2019, 14:50

Extract spellcheck change in D3708

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6909: Diff 10385.Jul 22 2019, 19:45

jasonbcox accepted this revision.Jul 22 2019, 20:07

This revision is now accepted and ready to land.Jul 22 2019, 20:07

Closed by commit rABCb4bccba1f5f3: Nits in Qt test (authored by deadalnix). · Explain WhyJul 23 2019, 00:16

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCb4bccba1f5f3: Nits in Qt test.

deadalnix added a commit: rSTAGINGb4bccba1f5f3: Nits in Qt test.Sep 19 2019, 01:22

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

util.h

2 lines

util.cpp

6 lines

Diff 10315

View Options

src/qt/test/util.h