As per title
Details
Details
- Reviewers
jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGINGc23bae12622f: Use nullptr instead of 0 in various places in Qt code
rABCc23bae12622f: Use nullptr instead of 0 in various places in Qt code
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- nullptrqt
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6922 Build 11891: Bitcoin ABC Buildbot (legacy) Build 11890: arc lint + arc unit
Event Timeline
src/qt/walletview.h | ||
---|---|---|
39 | As far as I understand, member initializers do not impact whether or not this constructor should be explicit. What's the benefit here (and does it belong in this diff?) |
src/qt/walletview.h | ||
---|---|---|
39 | This is always explicit because there is more than one parameter. |
src/qt/walletview.h | ||
---|---|---|
39 | I see. And this change doesn't apply to the other constructors because the second param has a default (the constructors can still be called with one param). |