Page MenuHomePhabricator
Differential D3719

Use nullptr instead of 0 in various places in Qt code
ClosedPublic
Actions

Authored by deadalnix on Jul 23 2019, 16:39.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGc23bae12622f: Use nullptr instead of 0 in various places in Qt code
rABCc23bae12622f: Use nullptr instead of 0 in various places in Qt code
Summary

As per title

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 23 2019, 16:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2019, 16:39
teamcity added a comment.Jul 23 2019, 16:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 23 2019, 16:45

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6922: Diff 10405.Jul 23 2019, 16:45
jasonbcox requested changes to this revision.Jul 23 2019, 17:07
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/walletview.h
39 ↗(On Diff #10405)

As far as I understand, member initializers do not impact whether or not this constructor should be explicit. What's the benefit here (and does it belong in this diff?)

This revision now requires changes to proceed.Jul 23 2019, 17:07
deadalnix requested review of this revision.Jul 23 2019, 17:33
deadalnix added inline comments.
src/qt/walletview.h
39 ↗(On Diff #10405)

This is always explicit because there is more than one parameter.

jasonbcox accepted this revision.Jul 23 2019, 18:26
jasonbcox added inline comments.
src/qt/walletview.h
39 ↗(On Diff #10405)

I see. And this change doesn't apply to the other constructors because the second param has a default (the constructors can still be called with one param).

This revision is now accepted and ready to land.Jul 23 2019, 18:26
Closed by commit rABCc23bae12622f: Use nullptr instead of 0 in various places in Qt code (authored by deadalnix). · Explain WhyJul 23 2019, 22:36
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCc23bae12622f: Use nullptr instead of 0 in various places in Qt code.
deadalnix added a commit: rSTAGINGc23bae12622f: Use nullptr instead of 0 in various places in Qt code.Sep 19 2019, 01:23

Revision Contents
Changeset List

Diff 10412

View Options

src/qt/sendcoinsdialog.h

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/qt/sendcoinsentry.h

Loading...
View Options

src/qt/sendcoinsentry.cpp

Loading...
View Options

src/qt/walletframe.h

Loading...
View Options

src/qt/walletview.h

Loading...
View Options

src/qt/walletview.cpp

Loading...