Page MenuHomePhabricator
Differential D3770

[tests] simplify binary and hex response parsing in interface_rest.py
ClosedPublic
Actions

Authored by Fabien on Jul 30 2019, 08:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa95d5f895de2: [tests] simplify binary and hex response parsing in interface_rest.py
rABCa95d5f895de2: [tests] simplify binary and hex response parsing in interface_rest.py
Summary
We use assert_greater_than_or_equal(), since the hex response contains
an extra b'\n' traling byte.

Partial backport of core PR12766 (commit 55efc1c)
https://github.com/bitcoin/bitcoin/pull/12766/commits/55efc1f62cef7e19efcb58ba68fbc2053bfa19a0

Depends on D3769

Test Plan
./test/functional/test_runner.py interface_rest

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12766_part6
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7001
Build 12049: Bitcoin ABC Buildbot (legacy)
Build 12048: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 30 2019, 08:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 30 2019, 08:32
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 30 2019, 08:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 30 2019, 08:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7001: Diff 10529.Jul 30 2019, 08:38
Fabien added a child revision: D3771: tests/tools: Enable additional Python flake8 rules for automatic linting.Jul 30 2019, 08:56
deadalnix accepted this revision.Aug 5 2019, 06:11
This revision is now accepted and ready to land.Aug 5 2019, 06:11
Closed by commit rABCa95d5f895de2: [tests] simplify binary and hex response parsing in interface_rest.py (authored by Roman Zeyde <me@romanzey.de>, committed by Fabien). · Explain WhyAug 5 2019, 07:06
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa95d5f895de2: [tests] simplify binary and hex response parsing in interface_rest.py.
Fabien added a commit: rSTAGINGa95d5f895de2: [tests] simplify binary and hex response parsing in interface_rest.py.Sep 19 2019, 01:35

Revision Contents
Changeset List

PathSize
test/
functional/
36 lines

Diff 10529

View Options

test/functional/interface_rest.py

Loading...