Page MenuHomePhabricator
Differential D3945

Improve formatting of developer notes
ClosedPublic
Actions

Authored by Fabien on Aug 26 2019, 16:57.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2138f2cd458f: Improve formatting of developer notes
rABC2138f2cd458f: Improve formatting of developer notes
Summary
Summary of changes:

 * Add a TOC to the page
 * Make tips and tricks section use h3 headings
 * Reformat and clarify some sections

Backport of core PR12759
https://github.com/bitcoin/bitcoin/pull/12759/files

Depends on D3961.

Test Plan

Read it and try the TOC with a compatible rendering software (I used
grip from https://github.com/joeyespo/grip).

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12759
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7258
Build 12561: Bitcoin ABC Buildbot (legacy)
Build 12560: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 26 2019, 16:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2019, 16:57
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 26 2019, 16:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 26 2019, 16:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 26 2019, 16:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 26 2019, 17:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7237: Diff 10954.Aug 26 2019, 17:10
Fabien added a child revision: D3947: [LINTER] Enforce using `#!/usr/bin/env bash` for shell scripts.Aug 26 2019, 17:21
Fabien updated this revision to Diff 10990.Aug 28 2019, 12:44

Rebase.

Fabien planned changes to this revision.Aug 28 2019, 12:45

Rebase issue

Fabien edited the summary of this revision. (Show Details)Aug 28 2019, 12:57
Fabien added a parent revision: D3961: [DOC] Fix out of order sections in the developer notes.
Fabien removed a parent revision: D3944: [docs] Add instructions for lcov coverage report generation.
Fabien updated this revision to Diff 10992.Aug 28 2019, 12:57

Rebase on top of D3961.

teamcity added a comment.Aug 28 2019, 13:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 28 2019, 13:16

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7258: Diff 10990.Aug 28 2019, 13:19
teamcity added a comment.Aug 28 2019, 13:19

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Aug 28 2019, 13:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7260: Diff 10992.Aug 28 2019, 13:28
deadalnix accepted this revision.Aug 28 2019, 14:18
This revision is now accepted and ready to land.Aug 28 2019, 14:18
Closed by commit rABC2138f2cd458f: Improve formatting of developer notes (authored by Evan Klitzke <evan@eklitzke.org>, committed by Fabien). · Explain WhyAug 29 2019, 06:07
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC2138f2cd458f: Improve formatting of developer notes.
Fabien added a commit: rSTAGING2138f2cd458f: Improve formatting of developer notes.Sep 19 2019, 02:03

Revision Contents
Changeset List

PathSize
doc/
129 lines

Diff 10990

View Options

doc/developer-notes.md

Loading...