Add missing override keyword to DummySignatureCreator::CreateSig()
ClosedPublic
Actions

Authored by Fabien on Sep 3 2019, 13:47.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING8f5f90aa1296: Add missing override keyword to DummySignatureCreator::CreateSig()
rABC8f5f90aa1296: Add missing override keyword to DummySignatureCreator::CreateSig()

Summary

This is an ovesight from D3889 which is throwing a warning at build
time.

Test Plan

Build and check there is no longer any -Winconsistent-missing-override
warning;

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_warning_override

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7304
Build 12651: Bitcoin ABC Buildbot (legacy)
Build 12650: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 3 2019, 13:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2019, 13:47

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix accepted this revision.Sep 3 2019, 13:57

This revision is now accepted and ready to land.Sep 3 2019, 13:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7304: Diff 11065.Sep 3 2019, 13:58

Closed by commit rABC8f5f90aa1296: Add missing override keyword to DummySignatureCreator::CreateSig() (authored by Fabien). · Explain WhySep 4 2019, 15:36

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC8f5f90aa1296: Add missing override keyword to DummySignatureCreator::CreateSig().

Fabien added a commit: rSTAGING8f5f90aa1296: Add missing override keyword to DummySignatureCreator::CreateSig().Sep 19 2019, 02:07

Revision Contents
Changeset List

Path

Size

src/

script/

sign.cpp

2 lines

Diff 11065

View Options

Add missing override keyword to DummySignatureCreator::CreateSig()ClosedPublicActions