Added empty block fallback to CreateNewBlock
Needs RevisionPublic
Actions

Authored by jasonbcox on Sep 9 2019, 20:02.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Summary

This provides a damage-control mechanism when invalid blocks are being erroneously generated for a new block template. While this is not bullet-proof against all conceivable bugs, it protects miners against issues with transaction inclusion, ordering, etc.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

empty-block-fallback-gbt-default

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7369
Build 12781: Bitcoin ABC Buildbot (legacy)
Build 12780: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 9 2019, 20:02

Herald added a reviewer: deadalnix. · View Herald TranscriptSep 9 2019, 20:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox planned changes to this revision.Sep 9 2019, 20:05

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7369: Diff 11170.Sep 9 2019, 20:09

Changed tests to call CreateNewBlock() with default params in as many places as possible. Improve existing tests so that a fallback empty block will not accidentally pass.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7370: Diff 11171.Sep 9 2019, 20:35

Build Bitcoin-ABC / Diffs / Diff Testing passed.

I don't think the design here is sound. You don't have an error boundary set anywhere, but a parameter that you pass down to ask what's downstream to not error out. This is not solid. The whole point of the maneuver is to not trust what downstream of the error boundary.

This revision now requires changes to proceed.Nov 17 2019, 22:01