Differential D4035

Remove redundant call to std::move
ClosedPublic
Actions

Authored by deadalnix on Sep 11 2019, 12:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGfb99a574e0aa: Remove redundant call to std::move
rABCfb99a574e0aa: Remove redundant call to std::move

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

redudantmove

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7386
Build 12815: Bitcoin ABC Buildbot (legacy)
Build 12814: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 11 2019, 12:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2019, 12:32

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7386: Diff 11191.Sep 11 2019, 12:40

deadalnix mentioned this in D4036: Add warning about redundant moves.Sep 11 2019, 12:43

Fabien accepted this revision.Sep 11 2019, 14:26

This revision is now accepted and ready to land.Sep 11 2019, 14:26

Closed by commit rABCfb99a574e0aa: Remove redundant call to std::move (authored by deadalnix). · Explain WhySep 11 2019, 14:32

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCfb99a574e0aa: Remove redundant call to std::move.

deadalnix mentioned this in rABC4b0c76696c1a: Add warning about redundant moves.

deadalnix added a commit: rSTAGINGfb99a574e0aa: Remove redundant call to std::move.Sep 19 2019, 02:13

deadalnix mentioned this in rSTAGING4b0c76696c1a: Add warning about redundant moves.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

wallet.cpp

2 lines

Diff 11191

View Options

Remove redundant call to std::moveClosedPublicActions