Page MenuHomePhabricator
Differential D4099

depends: qt: avoid system harfbuzz and bz2
ClosedPublic
Actions

Authored by Fabien on Sep 17 2019, 12:13.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8d8b46caeed0: depends: qt: avoid system harfbuzz and bz2
rABC8d8b46caeed0: depends: qt: avoid system harfbuzz and bz2
Summary
We may eventually want to break out harfbuzz and build it in depends,
but for now just ensure that runtime dependencies don't depend on
whether or not harfbuzz was present on the builder.

Backport of core PR14385
https://github.com/bitcoin/bitcoin/pull/14385/files

Test Plan

Regenerate the depends and run the gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14385
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7490
Build 13023: Bitcoin ABC Buildbot (legacy)
Build 13022: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 17 2019, 12:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2019, 12:13
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 17 2019, 12:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien planned changes to this revision.Sep 17 2019, 12:14

Hold on until the gitian builds are OK

teamcity added a comment.Sep 17 2019, 12:21

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Sep 17 2019, 12:23

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Sep 17 2019, 12:26

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7490: Diff 11361.Sep 17 2019, 12:26
teamcity added a comment.Sep 17 2019, 12:41

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Sep 17 2019, 12:41

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Sep 17 2019, 12:48

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Sep 17 2019, 12:50

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Fabien requested review of this revision.Sep 17 2019, 14:53

Gitian builds are OK

deadalnix accepted this revision.Sep 17 2019, 18:31
This revision is now accepted and ready to land.Sep 17 2019, 18:31
Closed by commit rABC8d8b46caeed0: depends: qt: avoid system harfbuzz and bz2 (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by Fabien). · Explain WhySep 18 2019, 09:13
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8d8b46caeed0: depends: qt: avoid system harfbuzz and bz2.
Fabien added a commit: rSTAGING8d8b46caeed0: depends: qt: avoid system harfbuzz and bz2.Sep 19 2019, 02:25

Revision Contents
Changeset List

PathSize
depends/
packages/
2 lines
1 line

Diff 11361

View Options

depends/packages/freetype.mk

Loading...
View Options

depends/packages/qt.mk

Loading...