Page MenuHomePhabricator
Differential D4111

[CMAKE] Always build obj/build.h
ClosedPublic
Actions

Authored by Fabien on Sep 19 2019, 12:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING6453c0073a74: [CMAKE] Always build obj/build.h
rABC6453c0073a74: [CMAKE] Always build obj/build.h
Summary

The file needs to be always generated.
This requires the use of a custom_target (always out of date) rather
than a custom_command.

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja

Check the buildcmake/obj/build.h file content matches your current
commit hash.
Amend the commit message then run ninja again: the
buildcmake/obj/build.h should be updated accordingly.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_build_h_always
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7510
Build 13060: Bitcoin ABC Buildbot (legacy)
Build 13059: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 19 2019, 12:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 19 2019, 12:05
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 19 2019, 12:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster failed remote builds in B7510: Diff 12980!Sep 19 2019, 12:05
teamcity added a comment.Sep 19 2019, 12:05

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Fabien updated this revision to Diff 12981.Sep 19 2019, 12:08

Missed a comment

teamcity added a comment.Sep 19 2019, 12:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 19 2019, 12:08

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7511: Diff 12981!Sep 19 2019, 12:08
Fabien planned changes to this revision.Sep 19 2019, 12:09
Fabien updated this revision to Diff 12982.Sep 19 2019, 12:27
Fabien edited the summary of this revision. (Show Details)

Simplify things by only keeping the target.

teamcity added a comment.Sep 19 2019, 12:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 19 2019, 12:28

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7512: Diff 12982!Sep 19 2019, 12:28
deadalnix requested changes to this revision.Sep 19 2019, 12:38

The dependencies are obviously incorrect (there are none).

This revision now requires changes to proceed.Sep 19 2019, 12:38
Fabien updated this revision to Diff 12983.Sep 19 2019, 13:18

Make build_header a dependency to util.

teamcity added a comment.Sep 19 2019, 13:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 19 2019, 13:19

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7513: Diff 12983!Sep 19 2019, 13:19
deadalnix requested changes to this revision.Sep 19 2019, 13:40
deadalnix added inline comments.
src/CMakeLists.txt
175 ↗(On Diff #12983)

ALL is not required here.

213 ↗(On Diff #12983)

Have you tried to specify the header as byproduct and then define the header as a depency on util? It is not the role of util to know how this header is generated.

This revision now requires changes to proceed.Sep 19 2019, 13:40
Fabien updated this revision to Diff 12984.Sep 19 2019, 14:36
Fabien edited the summary of this revision. (Show Details)

Remove ALL property.

teamcity added a comment.Sep 19 2019, 14:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 19 2019, 14:36

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7514: Diff 12984!Sep 19 2019, 14:36
Fabien added inline comments.Sep 19 2019, 14:45
src/CMakeLists.txt
213 ↗(On Diff #12983)

BYPRODUCTS is not supported for setting dependencies if another generator than ninja is used.

deadalnix accepted this revision.Sep 19 2019, 17:44
This revision is now accepted and ready to land.Sep 19 2019, 17:44
teamcity added a comment.Sep 20 2019, 07:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 20 2019, 07:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7514: Diff 12984.Sep 20 2019, 07:57
Closed by commit rABC6453c0073a74: [CMAKE] Always build obj/build.h (authored by Fabien). · Explain WhySep 20 2019, 07:58
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC6453c0073a74: [CMAKE] Always build obj/build.h.
Fabien added a commit: rSTAGING6453c0073a74: [CMAKE] Always build obj/build.h.Sep 27 2019, 22:45

Revision Contents
Changeset List

PathSize
src/
10 lines

Diff 12980

View Options

src/CMakeLists.txt

Loading...