Paths

Table of Contentst

Differential D4152

[CMAKE] Detect if the compiler supports visibility function attribute
ClosedPublic
Actions

Authored by Fabien on Sep 25 2019, 18:45.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGcd0f483aa801: [CMAKE] Detect if the compiler supports visibility function attribute
rABCcd0f483aa801: [CMAKE] Detect if the compiler supports visibility function attribute

Summary

This diff adds detection for the
__attribute__((visibility("default"))) and
__attribute__((visibility("default"))) visibility function attributes.

This allow to export the expected symbols when building a shared library
while using fvisibility=hidden.

Test Plan

mkdir buildcmake && cd buildcmake
cmake -GNinja ..
grep HAVE_FUNC_ATTRIBUTE src/config/bitcoin-config.h

Should be defined to 1 for HAVE_FUNC_ATTRIBUTE_VISIBILITY and
undefined for HAVE_FUNC_ATTRIBUTE_DLLEXPORT when using Clang, and
should be both defined to 1 when using GCC.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_check_function_attributes

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7586
Build 13212: Bitcoin ABC Buildbot (legacy)
Build 13211: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 25 2019, 18:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2019, 18:45

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7586: Diff 13137.Sep 25 2019, 18:58

deadalnix accepted this revision.Sep 26 2019, 13:45

deadalnix added inline comments.

src/config/bitcoin-config.h.cmake.in
55	WAT ?

This revision is now accepted and ready to land.Sep 26 2019, 13:45

Fabien added inline comments.Sep 26 2019, 14:29

src/config/bitcoin-config.h.cmake.in
55	It's from a backport that fixes an issue with serialization on OpenSolaris OS and derived.

Closed by commit rABCcd0f483aa801: [CMAKE] Detect if the compiler supports visibility function attribute (authored by Fabien). · Explain WhySep 26 2019, 14:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCcd0f483aa801: [CMAKE] Detect if the compiler supports visibility function attribute.

Fabien added a commit: rSTAGINGcd0f483aa801: [CMAKE] Detect if the compiler supports visibility function attribute.Sep 27 2019, 22:49

Revision Contents
Changeset List

Path

Size

src/

config/

12 lines

bitcoin-config.h.cmake.in

3 lines

Diff 13137

src/config/CMakeLists.txt

Loading...

src/config/bitcoin-config.h.cmake.in

Loading...