Drop ParseHashUV in favor of calling ParseHashStr
ClosedPublic
Actions

Authored by deadalnix on Oct 5 2019, 19:09.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa5735aaa11de: Drop ParseHashUV in favor of calling ParseHashStr
rABCa5735aaa11de: Drop ParseHashUV in favor of calling ParseHashStr

Summary

The one existing call already validates get_str will
pass via checkObject.

This is a backport of Core PR13422

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 5 2019, 19:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2019, 19:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7695: Diff 13365.Oct 5 2019, 19:25

Fabien accepted this revision.Oct 7 2019, 07:36

This revision is now accepted and ready to land.Oct 7 2019, 07:36

Closed by commit rABCa5735aaa11de: Drop ParseHashUV in favor of calling ParseHashStr (authored by Ben Woosley <ben.woosley@gmail.com>, committed by deadalnix). · Explain WhyOct 7 2019, 12:49

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCa5735aaa11de: Drop ParseHashUV in favor of calling ParseHashStr.

deadalnix added a commit: rSTAGINGa5735aaa11de: Drop ParseHashUV in favor of calling ParseHashStr.Oct 9 2019, 20:11

Revision Contents
Changeset List

Path

Size

src/

bitcoin-tx.cpp

2 lines

core_io.h

1 line

core_read.cpp

10 lines

Diff 13374

View Options

src/bitcoin-tx.cpp

View Options

src/core_io.h

View Options

Drop ParseHashUV in favor of calling ParseHashStrClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13374

src/bitcoin-tx.cpp

src/core_io.h

src/core_read.cpp

Drop ParseHashUV in favor of calling ParseHashStr
ClosedPublic
Actions

Revision Contents
Changeset List