Differential D4256

[CMAKE] Add resource file to bitcoin-qt
ClosedPublic
Actions

Authored by Fabien on Oct 15 2019, 08:37.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING1c3cb55f195b: [CMAKE] Add resource file to bitcoin-qt
rABC1c3cb55f195b: [CMAKE] Add resource file to bitcoin-qt

Summary

The resource file is missing from bitcoin-qt in the windows build. Other
executables have the resource file set correctly.

Test Plan

Cross build for Windows with CMake. Check the `bitcoin-qt.exe`

executable embeds its icon.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_add_qt_rc_file

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7774
Build 13587: Bitcoin ABC Buildbot (legacy)
Build 13586: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 15 2019, 08:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2019, 08:37

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7774: Diff 13559.Oct 15 2019, 08:48

deadalnix accepted this revision.Oct 15 2019, 10:38

This revision is now accepted and ready to land.Oct 15 2019, 10:38

Closed by commit rABC1c3cb55f195b: [CMAKE] Add resource file to bitcoin-qt (authored by Fabien). · Explain WhyOct 16 2019, 06:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1c3cb55f195b: [CMAKE] Add resource file to bitcoin-qt.

Fabien added a commit: rSTAGING1c3cb55f195b: [CMAKE] Add resource file to bitcoin-qt.Apr 7 2020, 21:26

Revision Contents
Changeset List

Path

Size

src/

qt/

CMakeLists.txt

3 lines

Diff 13559

View Options

[CMAKE] Add resource file to bitcoin-qtClosedPublicActions