Page MenuHomePhabricator
Differential D4257

[CMAKE] Propagate requirements for cmake >= 3.12
ClosedPublic
Actions

Authored by Fabien on Oct 15 2019, 12:22.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGd6f375f2c914: [CMAKE] Propagate requirements for cmake >= 3.12
rABCd6f375f2c914: [CMAKE] Propagate requirements for cmake >= 3.12
Summary

D4229 introduces the requirement for cmake >= 3.12.
Take advantages of the new features available from cmake >= 3.12 to
simplify the code a bit. Also the new project properties come in handy
when using CPack.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_minimum_3_12
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7786
Build 13611: Bitcoin ABC Buildbot (legacy)
Build 13610: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 15 2019, 12:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2019, 12:22
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Oct 15 2019, 12:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7775: Diff 13560.Oct 15 2019, 12:38
teamcity added a comment.Oct 15 2019, 12:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Oct 15 2019, 13:44

You shouldn't have made this dependent on the other

This revision is now accepted and ready to land.Oct 15 2019, 13:44
Fabien updated this revision to Diff 13573.Oct 16 2019, 06:56

Revert diff dependency.

Fabien edited the summary of this revision. (Show Details)Oct 16 2019, 06:56
Fabien removed a parent revision: D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
teamcity added a comment.Oct 16 2019, 06:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien mentioned this in D4229: [CMAKE] Build bitcoinconsensus library both static and shared.Oct 16 2019, 06:58
Fabien added a child revision: D4229: [CMAKE] Build bitcoinconsensus library both static and shared.Oct 16 2019, 06:58
Harbormaster completed remote builds in B7786: Diff 13573.Oct 16 2019, 07:07
teamcity added a comment.Oct 16 2019, 07:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABCd6f375f2c914: [CMAKE] Propagate requirements for cmake >= 3.12 (authored by Fabien). · Explain WhyOct 18 2019, 13:28
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd6f375f2c914: [CMAKE] Propagate requirements for cmake >= 3.12.
Fabien removed a child revision: D4229: [CMAKE] Build bitcoinconsensus library both static and shared.Oct 28 2019, 15:04
Fabien added a commit: rSTAGINGd6f375f2c914: [CMAKE] Propagate requirements for cmake >= 3.12.Apr 7 2020, 21:27

Revision Contents
Changeset List

PathSize
7 lines
src/
8 lines

Diff 13573

View Options

CMakeLists.txt

Loading...
View Options

src/CMakeLists.txt

Loading...