Page MenuHomePhabricator
Differential D4284

[CMAKE] Move package name and copyright to the top level
ClosedPublic
Actions

Authored by Fabien on Oct 23 2019, 11:50.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGc2d1db0a7ef1: [CMAKE] Move package name and copyright to the top level
rABCc2d1db0a7ef1: [CMAKE] Move package name and copyright to the top level
Summary

This makes it available outside of the config subdirectory, which is
useful for building the graphical installers.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_move_common_definition_on_top
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7843
Build 13707: Bitcoin ABC Buildbot (legacy)
Build 13706: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 23 2019, 11:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2019, 11:50
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Oct 23 2019, 11:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien updated this revision to Diff 13657.Oct 23 2019, 11:56

Update package vendor to match copyright holder.

teamcity added a comment.Oct 23 2019, 11:56

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 23 2019, 11:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7842: Diff 13656.Oct 23 2019, 11:59
Fabien mentioned this in D4274: [CMAKE] Create a windows installer.Oct 23 2019, 12:09
Fabien added a child revision: D4274: [CMAKE] Create a windows installer.Oct 23 2019, 12:09
teamcity added a comment.Oct 23 2019, 12:11

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7843: Diff 13657.Oct 23 2019, 12:11
deadalnix accepted this revision.Oct 23 2019, 16:10
This revision is now accepted and ready to land.Oct 23 2019, 16:10
Closed by commit rABCc2d1db0a7ef1: [CMAKE] Move package name and copyright to the top level (authored by Fabien). · Explain WhyOct 24 2019, 06:54
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCc2d1db0a7ef1: [CMAKE] Move package name and copyright to the top level.
Fabien added a commit: rSTAGINGc2d1db0a7ef1: [CMAKE] Move package name and copyright to the top level.Apr 7 2020, 21:29

Revision Contents
Changeset List

PathSize
9 lines
cmake/
modules/
2 lines
src/
config/
9 lines

Diff 13657

View Options

CMakeLists.txt

Loading...
View Options

cmake/modules/PackageOptions.cmake

Loading...
View Options

src/config/CMakeLists.txt

Loading...