Page MenuHomePhabricator
Differential D4497

Move BitcoinApplication to header so it can be tested
ClosedPublic
Actions

Authored by Fabien on Nov 21 2019, 09:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING66854b0c970f: Move BitcoinApplication to header so it can be tested
rABC66854b0c970f: Move BitcoinApplication to header so it can be tested
Summary

Move-only commit, no code changes

Partial backport of core PR11625 (commit 7e4bd19)
https://github.com/bitcoin/bitcoin/pull/11625/commits/ca20b65cc04825bb317f1a59d02c77912f6bf097

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11625_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8210
Build 14446: Default Diff Build & Tests
Build 14445: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 21 2019, 09:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2019, 09:09
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 21 2019, 09:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 21 2019, 09:19

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8208: Diff 14284.Nov 21 2019, 09:20
deadalnix requested changes to this revision.Nov 21 2019, 12:09
deadalnix added inline comments.
src/qt/bitcoin.h
12 ↗(On Diff #14284)

You don't need this.

14 ↗(On Diff #14284)

You probably don't need these two either.

This revision now requires changes to proceed.Nov 21 2019, 12:09
Fabien updated this revision to Diff 14286.Nov 21 2019, 12:53

Use forward declarations

teamcity added a comment.Nov 21 2019, 12:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 21 2019, 13:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8210: Diff 14286.Nov 21 2019, 13:03
deadalnix accepted this revision.Nov 21 2019, 14:36
This revision is now accepted and ready to land.Nov 21 2019, 14:36
Closed by commit rABC66854b0c970f: Move BitcoinApplication to header so it can be tested (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyNov 21 2019, 14:54
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC66854b0c970f: Move BitcoinApplication to header so it can be tested.
Fabien added a commit: rSTAGING66854b0c970f: Move BitcoinApplication to header so it can be tested.Apr 7 2020, 21:46

Revision Contents
Changeset List

PathSize
src/
3 lines
qt/
129 lines
101 lines

Diff 14286

View Options

src/Makefile.qt.include

Loading...
View Options

src/qt/bitcoin.h

Loading...
View Options

src/qt/bitcoin.cpp

Loading...