Page MenuHomePhabricator
Differential D4501

util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool
ClosedPublic
Actions

Authored by deadalnix on Nov 21 2019, 14:13.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING8a31c2afd39f: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool
rABC8a31c2afd39f: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool
Summary
  • miner: Default to DEFAULT_BLOCK_MIN_TX_FEE if unable to parse -blockmintxfee
  • tests: Check return value of ParseParameters(...)
  • tests: Explicitly ignore the return value of DecodeBase58(...)
  • Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.

This is a backport of Core PR13815

Depends on D4500

Test Plan

Build and make sure there is no arnign due to discarded result.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13815
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8214
Build 14454: Default Diff Build & Tests
Build 14453: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 21 2019, 14:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2019, 14:13
teamcity added a comment.Nov 21 2019, 14:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 21 2019, 14:29

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8214: Diff 14290.Nov 21 2019, 14:29
jasonbcox accepted this revision.Nov 21 2019, 20:01
jasonbcox added a subscriber: jasonbcox.

The build plan is ambiguous, so I trust you did both make and ninja

src/attributes.h
1

Pretty sure Satoshi didn't author this file :P
but this is in the original PR, so w/e I guess.

This revision is now accepted and ready to land.Nov 21 2019, 20:01
Closed by commit rABC8a31c2afd39f: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhyNov 21 2019, 23:27
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC8a31c2afd39f: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool.
deadalnix added a commit: rSTAGING8a31c2afd39f: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool.Apr 7 2020, 21:47

Revision Contents
Changeset List

PathSize
src/
1 line
22 lines
12 lines
bench/
2 lines
10 lines
6 lines
3 lines
1 line
script/
3 lines
test/
2 lines
44 lines
util/
5 lines
19 lines
2 lines
5 lines

Diff 14290

View Options

src/Makefile.am

Loading...
View Options

src/attributes.h

Loading...
View Options

src/base58.h

Loading...
View Options

src/bench/base58.cpp

Loading...
View Options

src/core_io.h

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/outputtype.h

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/script/descriptor.cpp

Loading...
View Options

src/test/getarg_tests.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/moneystr.h

Loading...
View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...
View Options

src/util/system.h

Loading...