Page MenuHomePhabricator
Differential D4607

[cmake] link test runners by default
ClosedPublic
Actions

Authored by deadalnix on Dec 1 2019, 02:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING36791c4a595c: [cmake] link test runners by default
rABC36791c4a595c: [cmake] link test runners by default
Summary

This is not an expensive operation, is properly tracked by dependencies and ensure the presence of these file is predictable.

Test Plan
rm test/functional/test_runner.py
ninja

Check test/functional/test_runner.py was linked.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmakewoes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8365
Build 14749: Default Diff Build & Tests
Build 14748: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 1 2019, 02:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2019, 02:19
teamcity added a comment.Dec 1 2019, 02:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix updated this revision to Diff 14547.Dec 1 2019, 02:30

map the sanitization with cmake doc ( https://cmake.org/cmake/help/v3.10/policy/CMP0037.html ) and reduce verbosity.

teamcity added a comment.Dec 1 2019, 02:30

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 1 2019, 02:30

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8363: Diff 14546.Dec 1 2019, 02:30
deadalnix updated this revision to Diff 14548.Dec 1 2019, 02:37

Use absolute path

teamcity added a comment.Dec 1 2019, 02:37

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 1 2019, 02:41

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8364: Diff 14547.Dec 1 2019, 02:41
teamcity added a comment.Dec 1 2019, 02:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8365: Diff 14548.Dec 1 2019, 02:47
Fabien accepted this revision.Dec 2 2019, 08:47
Fabien added a subscriber: Fabien.

Thanks, this one was on my list :)

This revision is now accepted and ready to land.Dec 2 2019, 08:47
Closed by commit rABC36791c4a595c: [cmake] link test runners by default (authored by deadalnix). · Explain WhyDec 2 2019, 14:03
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC36791c4a595c: [cmake] link test runners by default.
deadalnix added a commit: rSTAGING36791c4a595c: [cmake] link test runners by default.Apr 7 2020, 21:57

Revision Contents
Changeset List

PathSize
cmake/
modules/
7 lines
test/
27 lines

Diff 14548

View Options

cmake/modules/SanitizeHelper.cmake

Loading...
View Options

test/CMakeLists.txt

Loading...