Page MenuHomePhabricator
Differential D4630

test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD
ClosedPublic
Actions

Authored by Fabien on Dec 4 2019, 16:13.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING6988f8f073d5: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD
rABC6988f8f073d5: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD
Summary

Partial backport of core PR15504 (commit fab2daa):
https://github.com/bitcoin/bitcoin/pull/15504/commits/fab2daa026494cdacda530f1253eb43cf0f1576c

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15504_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8403
Build 14823: Default Diff Build & Tests
Build 14822: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 4 2019, 16:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2019, 16:13
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 4 2019, 16:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 4 2019, 16:23

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B8403: Diff 14613!Dec 4 2019, 16:23
deadalnix requested changes to this revision.Dec 4 2019, 23:13

Looks like you broke the build.

This revision now requires changes to proceed.Dec 4 2019, 23:13
teamcity added a comment.Dec 5 2019, 07:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 5 2019, 07:27

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien requested review of this revision.Dec 5 2019, 07:41

It was an unrelated failure, build is green now

teamcity added a comment.Dec 5 2019, 21:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 5 2019, 21:39

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8403: Diff 14613.Dec 5 2019, 21:39
deadalnix accepted this revision.Dec 6 2019, 11:08
This revision is now accepted and ready to land.Dec 6 2019, 11:08
Closed by commit rABC6988f8f073d5: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyDec 18 2019, 20:14
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC6988f8f073d5: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD.
Fabien added a commit: rSTAGING6988f8f073d5: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD.Apr 7 2020, 22:08

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 14613

View Options

src/Makefile.test.include

Loading...