[rpc] Finish backporting changes to prioritisetransaction's priority_delta argument
ClosedPublic
Actions

Authored by markblundeberg on Jan 4 2020, 02:09.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING7dbf277ad363: [rpc] Finish backporting changes to prioritisetransaction's priority_delta…
rABC7dbf277ad363: [rpc] Finish backporting changes to prioritisetransaction's priority_delta…

Summary

prioritisetransaction RPC had this argument removed in PR9602, then re-added in
PR10252, then re-named in PR10488.
https://github.com/bitcoin/bitcoin/pull/9602/commits/f9b9371c6027905f73a2558d6bcaca8a355c28a6
https://github.com/bitcoin/bitcoin/pull/10252/files
https://github.com/bitcoin/bitcoin/pull/10488/files

Since the intermediate states are undesirable and I already did the renaming
to 'dummy' in D4812 (landed), this pulls together the overall remaining effects
of the PRs which are ultimately small:

modify documentation slightly and force argument to be 0 instead of ignoring.
change RPC tests to not pass priority, and use keyword arguments instead.
simplify mining_prioritisetransaction test slightly (from 9602).

The release note is taken verbatim from Core's 0.15 release notes.

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jan 4 2020, 02:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 4 2020, 02:09

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added inline comments.Jan 4 2020, 02:10

src/rpc/mining.cpp
271 ↗	(On Diff #15145)	this will be eventually changed 'back' in https://github.com/bitcoin/bitcoin/pull/14720/files#diff-9651347c8e00bed3ddc7631de569406dL235 but I think this is good for now