[CMAKE] Don't use C++ features for building secp256k1
ClosedPublic
Actions

Authored by Fabien on Jan 8 2020, 14:11.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING3dea66f3fed8: [CMAKE] Don't use C++ features for building secp256k1
rABC3dea66f3fed8: [CMAKE] Don't use C++ features for building secp256k1

Summary

Secp256k1 is a pure C library. As such there should be no requirement
for a C++ compiler to be able to build it.

Test Plan

Build secp256k1 as part of bitcoin-abc and as a standalone project:

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_secp256k1_c

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8781
Build 15543: Default Diff Build & Tests
Build 15542: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 8 2020, 14:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2020, 14:11

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8781: Diff 15220.Jan 8 2020, 14:16

deadalnix accepted this revision.Jan 8 2020, 17:19

This revision is now accepted and ready to land.Jan 8 2020, 17:19

Closed by commit rABC3dea66f3fed8: [CMAKE] Don't use C++ features for building secp256k1 (authored by Fabien). · Explain WhyJan 9 2020, 07:09

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3dea66f3fed8: [CMAKE] Don't use C++ features for building secp256k1.

Fabien added a commit: rSTAGING3dea66f3fed8: [CMAKE] Don't use C++ features for building secp256k1.Apr 7 2020, 22:19

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

CMakeLists.txt

7 lines

Diff 15220

View Options

src/secp256k1/CMakeLists.txt

[CMAKE] Don't use C++ features for building secp256k1ClosedPublicActions