Differential D4876

Nits in rpcdump
ClosedPublic
Actions

Authored by deadalnix on Jan 9 2020, 13:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING4941397cc777: Nits in rpcdump
rABC4941397cc777: Nits in rpcdump

Summary

Leaner casts and better pecision in some computations.

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rpcdump

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8815
Build 15605: Default Diff Build & Tests
Build 15604: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 9 2020, 13:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 9 2020, 13:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8815: Diff 15270.Jan 9 2020, 13:40

Fabien requested changes to this revision.Jan 9 2020, 15:03

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/wallet/rpcdump.cpp
736	You may want to update this one as well

This revision now requires changes to proceed.Jan 9 2020, 15:03

Do the other one as well

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8820: Diff 15279.Jan 9 2020, 16:50

Fabien accepted this revision.Jan 9 2020, 16:52

This revision is now accepted and ready to land.Jan 9 2020, 16:52

Closed by commit rABC4941397cc777: Nits in rpcdump (authored by deadalnix). · Explain WhyJan 9 2020, 16:56

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC4941397cc777: Nits in rpcdump.

deadalnix added a commit: rSTAGING4941397cc777: Nits in rpcdump.Apr 7 2020, 22:20

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcdump.cpp

4 lines

Diff 15270

View Options

Nits in rpcdumpClosedPublicActions