Page MenuHomePhabricator

Log env path in BerkeleyEnvironment::Flush
ClosedPublic

Authored by Fabien on Jan 10 2020, 17:28.

Details

Summary

With bitcoind -regtest -wallet=w1 -wallet=w2 -debug, before:

BerkeleyEnvironment::Flush: Flush(true)
BerkeleyEnvironment::Flush: Flushing wallet.dat (refcount = 0)...
BerkeleyEnvironment::Flush: wallet.dat checkpoint
BerkeleyEnvironment::Flush: wallet.dat detach
BerkeleyEnvironment::Flush: wallet.dat closed
BerkeleyEnvironment::Flush: Flush(true) took              23ms
BerkeleyEnvironment::Flush: Flush(true)
BerkeleyEnvironment::Flush: Flushing wallet.dat (refcount = 0)...
BerkeleyEnvironment::Flush: wallet.dat checkpoint
BerkeleyEnvironment::Flush: wallet.dat detach
BerkeleyEnvironment::Flush: wallet.dat closed
BerkeleyEnvironment::Flush: Flush(true) took              19ms

After:

BerkeleyEnvironment::Flush: [/Users/joao/Library/Application
Support/Bitcoin/regtest/wallets/w1] Flush(true)
BerkeleyEnvironment::Flush: Flushing wallet.dat (refcount = 0)...
BerkeleyEnvironment::Flush: wallet.dat checkpoint
BerkeleyEnvironment::Flush: wallet.dat detach
BerkeleyEnvironment::Flush: wallet.dat closed
BerkeleyEnvironment::Flush: Flush(true) took              23ms
BerkeleyEnvironment::Flush: [/Users/joao/Library/Application
Support/Bitcoin/regtest/wallets/w2] Flush(true)
BerkeleyEnvironment::Flush: Flushing wallet.dat (refcount = 0)...
BerkeleyEnvironment::Flush: wallet.dat checkpoint
BerkeleyEnvironment::Flush: wallet.dat detach
BerkeleyEnvironment::Flush: wallet.dat closed
BerkeleyEnvironment::Flush: Flush(true) took              19ms

Backport of core PR14760:
https://github.com/bitcoin/bitcoin/pull/14760/files

Depends on D4885.

Test Plan
ninja

Launch bitcoind, kill it, and check the output is compliant with the
diff
summary.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14760
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8835
Build 15645: Default Diff Build & Tests
Build 15644: arc lint + arc unit