Page MenuHomePhabricator

Fix -Wshadow warnings
ClosedPublic

Authored by Fabien on Jan 13 2020, 12:40.

Details

Summary

These warnings have been introduced in D4891.

Test Plan

With GCC (for some reason clang -tested with 9.0.1- doesn't report the
warning):

cmake -GNinja .. -DCMAKE_CXX_FLAGS="-Werror=shadow"
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_shadow_warnings
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8891
Build 15757: Default Diff Build & Tests
Build 15756: arc lint + arc unit