Optimize secp256k1_fe_normalize_weak calls.
ClosedPublic
Actions

Authored by deadalnix on Jan 17 2020, 01:05.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING72a05b3a0de3: Optimize secp256k1_fe_normalize_weak calls.
rABC72a05b3a0de3: Optimize secp256k1_fe_normalize_weak calls.

Summary

Move secp256k1_fe_normalize_weak calls out of ECMULT_TABLE_GET_GE and ECMULT_TABLE_GET_GE_STORAGE and into secp256k1_ge_globalz_set_table_gej instead.

This is a backport of secp256k1's PR550

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secppr550

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8996
Build 15954: Default Diff Build & Tests
Build 15953: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 17 2020, 01:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 01:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8996: Diff 15547.Jan 17 2020, 01:18

Fabien accepted this revision.Jan 17 2020, 10:13

This revision is now accepted and ready to land.Jan 17 2020, 10:13

Closed by commit rABC72a05b3a0de3: Optimize secp256k1_fe_normalize_weak calls. (authored by Russell O'Connor <roconnor@blockstream.io>, committed by deadalnix). · Explain WhyJan 17 2020, 11:47

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC72a05b3a0de3: Optimize secp256k1_fe_normalize_weak calls..

deadalnix added a commit: rSTAGING72a05b3a0de3: Optimize secp256k1_fe_normalize_weak calls..Apr 7 2020, 22:30

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

ecmult_impl.h

5 lines

group_impl.h

2 lines

Diff 15547

View Options

src/secp256k1/src/ecmult_impl.h